Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ParamEnv docs #123327

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Update ParamEnv docs #123327

merged 2 commits into from
Apr 2, 2024

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Apr 1, 2024

There is now a wealth of information in the dev guide about ParamEnv so we should explicitly link to it from the doc comments. I also added a caution against using ParamEnv and removed the comment about it being "suitable for type checking" as you should practically never use ParamEnv::empty for type checking

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 1, 2024
compiler-errors
compiler-errors approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 1, 2024

📌 Commit a91f622 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#123327 - BoxyUwU:param_env_docs_rewrite, r=…
4cf7d2e 
…compiler-errors

Update `ParamEnv` docs

There is now a wealth of information in the dev guide about `ParamEnv` so we should explicitly link to it from the doc comments. I also added a caution against using `ParamEnv` and removed the comment about it being "suitable for type checking" as you should practically never use `ParamEnv::empty` for type checking

r? `@compiler-errors`
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 1, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#123327 - BoxyUwU:param_env_docs_rewrite, r=…
8ab2449 
…compiler-errors

Update `ParamEnv` docs

There is now a wealth of information in the dev guide about `ParamEnv` so we should explicitly link to it from the doc comments. I also added a caution against using `ParamEnv` and removed the comment about it being "suitable for type checking" as you should practically never use `ParamEnv::empty` for type checking

r? ``@compiler-errors``
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 1, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

tragic, my day is ruined

@bors r-

r=me when fixed :3

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2024
@workingjubilee
Copy link
Member

Yes, that should be correct.

@workingjubilee
Copy link
Member

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Apr 1, 2024

📌 Commit 03dd329 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2024
@workingjubilee workingjubilee mentioned this pull request Apr 1, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Apr 1, 2024
@workingjubilee
Rollup merge of rust-lang#123327 - BoxyUwU:param_env_docs_rewrite, r=…
f31464b 
…compiler-errors

Update `ParamEnv` docs

There is now a wealth of information in the dev guide about `ParamEnv` so we should explicitly link to it from the doc comments. I also added a caution against using `ParamEnv` and removed the comment about it being "suitable for type checking" as you should practically never use `ParamEnv::empty` for type checking

r? `@compiler-errors`
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2024
@bors
Auto merge of rust-lang#123335 - workingjubilee:rollup-4882hjs, r=wor…
829eb70 
…kingjubilee

Rollup of 3 pull requests

Successful merges:

 - rust-lang#123320 (Fixup parsing of `rustc_never_type_options` attribute)
 - rust-lang#123323 (std::thread: set_name change for solaris/illumos.)
 - rust-lang#123327 (Update `ParamEnv` docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Apr 1, 2024

⌛ Testing commit 03dd329 with merge dd5e502...

@bors
Copy link
Contributor

bors commented Apr 2, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing dd5e502 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2024
@bors bors merged commit dd5e502 into rust-lang:master Apr 2, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 2, 2024
@bors bors mentioned this pull request Apr 2, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dd5e502): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.3% [4.3%, 4.3%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.3% [4.3%, 4.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.149s -> 669.168s (0.15%)
Artifact size: 315.67 MiB -> 315.68 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@BoxyUwU @compiler-errors @bors @rust-log-analyzer @workingjubilee @rust-timer @rustbot