Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 541 pull requests #123328

Closed
wants to merge 8 commits into from
Closed

Rollup of 541 pull requests #123328

wants to merge 8 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

devnexen and others added 8 commits April 1, 2024 10:01
@devnexen
std::thread: adding get_name implementation for solaris/illumos.
747d193 
THREAD_NAME_MAX is 32 (31 max + 1 for the null terminator).
@TomAFrench
chore: fix footnotes/links in platform-support.md
edb7aea
@WaffleLapkin
Fixup parsing of rustc_never_type_options attribute
7107748 
Copy paste error strike again..
@BoxyUwU
Update ParamEnv docs
a91f622
@matthiaskrgr
Rollup merge of rust-lang#123315 - devnexen:thread_get_name_solaris, …
fe41814 
…r=ChrisDenton

std::thread: adding get_name implementation for solaris/illumos.

THREAD_NAME_MAX is 32 (31 max + 1 for the null terminator).
@matthiaskrgr
Rollup merge of rust-lang#123318 - TomAFrench:patch-1, r=GuillaumeGomez
814c3eb 
chore: fix footnotes/links in `platform-support.md`

A missing newline between two references is resulting in some links/footnotes not rendering properly. This PR fixes this.
@matthiaskrgr
Rollup merge of rust-lang#123320 - WaffleLapkin:fixup-never-type-opti…
a3140e0 
…ons, r=compiler-errors

Fixup parsing of `rustc_never_type_options` attribute

rust-lang#122843 had a copy paste error, which I did not caught when testing.

r? `@compiler-errors`
@matthiaskrgr
Rollup merge of rust-lang#123327 - BoxyUwU:param_env_docs_rewrite, r=…
4cf7d2e 
…compiler-errors

Update `ParamEnv` docs

There is now a wealth of information in the dev guide about `ParamEnv` so we should explicitly link to it from the doc comments. I also added a caution against using `ParamEnv` and removed the comment about it being "suitable for type checking" as you should practically never use `ParamEnv::empty` for type checking

r? `@compiler-errors`
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 1, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@matthiaskrgr matthiaskrgr changed the title Rollup of 4 pull requests Rollup of 541 pull requests Apr 1, 2024
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
 Documenting rustc_ast_pretty v0.0.0 (/checkout/compiler/rustc_ast_pretty)
error: unresolved link to `param_env_guide`
    --> compiler/rustc_middle/src/ty/mod.rs:1039:25
     |
1039 | /// [dev guide chapter](param_env_guide) for more information.
     |                         ^^^^^^^^^^^^^^^ no item named `param_env_guide` in scope
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
     = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

@fmease fmease mentioned this pull request Apr 1, 2024
Closed
@matthiaskrgr matthiaskrgr deleted the rollup-pjwyaoe branch September 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @rust-log-analyzer @rustbot @devnexen @TomAFrench @WaffleLapkin @BoxyUwU