CFI: Don't rewrite ty::Dynamic directly #123525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're using a type folder, the arguments in predicates are processed automatically - we don't need to descend manually. We also want to keep projection clauses around, and this does so.
rustbot
added
PG-exploit-mitigations
compiler-errors
approved these changes
Apr 6, 2024
|
so much cleaner haha -- i think the obviousness of doing this is clear from the fact that we now just fold dyn traits normally @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123294 (Require LLVM_CONFIG to be set in rustc_llvm/build.rs) - rust-lang#123467 (MSVC targets should use COFF as their archive format) - rust-lang#123498 (explaining `DefKind::Field`) - rust-lang#123519 (Improve cfg and check-cfg configuration) - rust-lang#123525 (CFI: Don't rewrite ty::Dynamic directly) - rust-lang#123526 (Do not ICE when calling incorrectly defined `transmute` intrinsic) - rust-lang#123528 (Hide async_gen_internals from standard library documentation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
Rollup merge of rust-lang#123525 - maurer:no-id-dyn2, r=compiler-errors CFI: Don't rewrite ty::Dynamic directly Now that we're using a type folder, the arguments in predicates are processed automatically - we don't need to descend manually. We also want to keep projection clauses around, and this does so. r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using a type folder, the arguments in predicates are processed automatically - we don't need to descend manually.
We also want to keep projection clauses around, and this does so.
r? @compiler-errors