Migrate run-make/doctests-keep-binaries to new rmake.rs format
#124658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
commented
May 3, 2024
| @@ -62,6 +62,12 @@ impl Rustdoc { | |||
| self | |||
| } | |||
|
|
|||
| /// Set the path where the command will be run. | |||
| pub fn current_dir<P: AsRef<Path>>(&mut self, path: P) -> &mut Self { | |||
There was a problem hiding this comment.
Should I add this method in Rustc too?
There was a problem hiding this comment.
That makes sense, or even in the impl_helper_methods macro to generate that for all command wrappers.
This comment has been minimized.
This comment has been minimized.
jieyouxu
reviewed
May 3, 2024
| @@ -62,6 +62,12 @@ impl Rustdoc { | |||
| self | |||
| } | |||
|
|
|||
| /// Set the path where the command will be run. | |||
| pub fn current_dir<P: AsRef<Path>>(&mut self, path: P) -> &mut Self { | |||
There was a problem hiding this comment.
That makes sense, or even in the impl_helper_methods macro to generate that for all command wrappers.
GuillaumeGomez
force-pushed
the
migrate-to-run-make
branch
from
7a627a1
to
34df542
Compare
rustbot
added
A-testsuite
|
Moved the implementation of |
jieyouxu
approved these changes
May 3, 2024
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
migrate-to-run-make
branch
from
34df542
to
07fe4e6
Compare
|
@bors r=jieyouxu |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 3, 2024
…, r=jieyouxu Migrate `run-make/doctests-keep-binaries` to new rmake.rs format r? `@jieyouxu`
|
@bors r- |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
migrate-to-run-make
branch
from
07fe4e6
to
5ea65c8
Compare
|
Now we can put it into the rollup: @bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 4, 2024
…, r=jieyouxu Migrate `run-make/doctests-keep-binaries` to new rmake.rs format r? `@jieyouxu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#124293 (Let miri and const eval execute intrinsics' fallback bodies) - rust-lang#124418 (Use a proof tree visitor to refine the `Obligation` for error reporting in new solver) - rust-lang#124480 (Change `SIGPIPE` ui from `#[unix_sigpipe = "..."]` to `-Zon-broken-pipe=...`) - rust-lang#124648 (Trim crate graph) - rust-lang#124656 (release notes 1.78: add link to interior-mut breaking change) - rust-lang#124658 (Migrate `run-make/doctests-keep-binaries` to new rmake.rs format) - rust-lang#124681 (zkvm: fix run_tests) - rust-lang#124687 (Make `Bounds.clauses` private) r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 4, 2024
…, r=jieyouxu Migrate `run-make/doctests-keep-binaries` to new rmake.rs format r? ``@jieyouxu``
This was referenced May 4, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#124418 (Use a proof tree visitor to refine the `Obligation` for error reporting in new solver) - rust-lang#124480 (Change `SIGPIPE` ui from `#[unix_sigpipe = "..."]` to `-Zon-broken-pipe=...`) - rust-lang#124648 (Trim crate graph) - rust-lang#124656 (release notes 1.78: add link to interior-mut breaking change) - rust-lang#124658 (Migrate `run-make/doctests-keep-binaries` to new rmake.rs format) - rust-lang#124678 (Stabilize `split_at_checked`) - rust-lang#124681 (zkvm: fix run_tests) - rust-lang#124687 (Make `Bounds.clauses` private) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
Rollup merge of rust-lang#124658 - GuillaumeGomez:migrate-to-run-make, r=jieyouxu Migrate `run-make/doctests-keep-binaries` to new rmake.rs format r? ```@jieyouxu```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876.
r? @jieyouxu