Tracking Issue for porting `run-make` tests to use Rust #121876

jieyouxu · 2024-03-01T22:39:10Z

We want to stop run-make tests from relying on make, and improve the run-make tests so that
they are more accessible to rustc contributors by allowing the tests to be written in Rust (see
#40713 for context). PR #113026 was merged to address this, and now we are able to write run-make
tests in Rust recipes. We would like your help to port over existing run-make tests still using
Makefiles to use Rust recipes instead.

If you would like to work on porting one of the run-make tests, please link to this issue in your
PR and leave a comment to claim the test (or multiple tests). If you are stuck, please don't hesitate to open a thread
on Rust's Zulip.

run-make is the most flexible fallback test kind, but some run-make tests could be migrated to become e.g. ui tests instead. Please check if you can convert the run-make test into other test kinds before porting!

When you try to port a test, also consider:

Add some comments on what the test is trying to test.
Add some comments on how the test tries to accomplish its goals if the test is non-trivial. This is especially true if you discovered that a test has platform/compiler/architecture/tooling-specific behavior that is a pain to debug.
Any related issues? Any relevant links?
Is the test still applicable? Has it become outdated? Is it duplicated?
Can it be written in other test suites?

Context: Rust recipes?

PR #113026 adds basic infrastructure support to write run-make tests using small Rust programs,
called recipes.

We aim to eliminate the dependency on make and Makefiles for building run-make-style tests.
Makefiles are replaced by recipes (rmake.rs). The PR implements running run-make recipes in
3 steps:

We build the support library run_make_support which the rmake.rs recipes depend on as a tool
lib.
We build the recipe rmake.rs and link in the support library.
We run the recipe to build and run the tests.

rmake.rs is basically a replacement for Makefile, and allows running arbitrary Rust code. The
support library is built using cargo, and so can depend on external crates if desired.

The infrastructure implemented by the PR is very barebones, and is the minimally required
infrastructure needed to build, run and pass the two example run-make tests ported over to the new
infrastructure:

You likely will find that you would need to improve the API of the support library, and extend
the functionality of the support library.

Common traps and pitfalls, and tips and tricks

$PATH uses ; on Windows and : for *nixes. Use std::env::{join,split}_paths to properly
handle $PATH.
Be careful of path separator platform differences. Always prefer PathBuf operations not string
paths if possible.
tests/ are not (currently) formatted by rustfmt.
Consult https://github.com/rust-lang/rust/blob/master/tests/run-make/tools.mk for which flags
and envs are passed to various executables or libraries. May have to triple check on those.
You can always request your reviewer to run try jobs to test out your PR on environments you don't locally have access to. Good candidate CI jobs include:
- aarch64-apple (apple, 64 bits, aarch64/arm64)
- armhf-gnu (cross-compile)
- test-various (cross-compile, wasm)
- x86_64-mingw (x86_64, 64 bits, windows, mingw)
- x86_64-msvc (x86_64, 64 bits, windows, msvc)
- x86_64-gnu-llvm-18 (x86_64, 64 bits, windows, gnu, llvm 18)
- i686-msvc (x86, 32 bits, windows, msvc)

Tests that need porting

alloc-no-oom-handling, alloc-no-rc, alloc-no-sync (Rewrite 3 very similar run-make alloc tests to rmake #125024)
allow-non-lint-warnings-cmdline (Migrate run-make/allow-non-lint-warnings-cmdline to rmake.rs #126386)
allow-warnings-cmdline-stability (Migrate run-make/allow-warnings-cmdline-stability to rmake.rs #125573)
arguments-non-c-like-enum (Port argument-non-c-like-enum to Rust #123149)
atomic-lock-free (Migrate atomic-lock-free to rmake #127787)
branch-protection-check-IBT (Ignore branch-protection-check-IBT run-make test #126720)
c-link-to-rust-dylib (Migrate run-make/c-link-to-rust-dylib to rmake.rs #125808)
c-link-to-rust-staticlib (Migrate run-make/c-link-to-rust-staticlib to rmake #125027)
c-link-to-rust-va-list-fn (Migrate run-make/c-link-to-rust-va-list-fn to rmake #125026)
c-unwind-abi-catch-lib-panic, foreign-rust-exceptions, export-executable-symbols (Migrate c-unwind-abi-catch-lib-panic, foreign-rust-exceptions and export-executable-symbols run-make tests to rmake #128065)
cat-and-grep-sanity-check (run-make: Delete cat-and-grep-sanity-check and restrict branch-protection-check-IBT to stable #129156)
cdylib (Migrate run make cdylib #125773)
cdylib-dylib-linkage (Migrate cdylib-dylib-linkage run-make test to rmake #128245)
codegen-options-parsing (Migrate run-make/codegen-options-parsing to rmake.rs #126478)
comment-section (Migrate run-make/comment-section to rmake.rs #126534)
compile-stdin (Migrate run-make/compile-stdin to rmake.rs #125607)
compiler-lookup-paths, dump-mono-stats, prune-link-args (Migrate compiler-lookup-paths, dump-mono-stats and prune-link-args run-make tests to rmake or ui format #126208)
compressed-debuginfo (Migrate run-make/compressed-debuginfo to rmake.rs #126629)
const-prop-lint (Migrate run-make/const-prop-lint to rmake.rs #125653)
const_fn_mir (Migrate run make const fn mir #126270)
core-no-fp-fmt-parse (Rewrite core-no-fp-fmt-parse test in Rust #123180)
crate-data-smoke (Migrate run-make/crate-data-smoke to rmake.rs #125723)
crate-hash-rustc-version (Migrate crate-hash-rustc-version to rmake #127693)
cross-lang-lto (Migrate cross-lang-lto run-make test to rmake #128352)
cross-lang-lto-clang, cross-lang-lto-pgo-smoketest (Migrate cross-lang-lto-clang and cross-lang-lto-pgo-smoketest run-make tests to rmake #128356)
cross-lang-lto-upstream-rlibs, long-linker-command-lines, long-linker-command-lines-cmd-exe (Migrate cross-lang-lto-upstream-rlibs, long-linker-command-lines and long-linker-command-lines-cmd-exe run-make tests to rmake #128196)
dep-graph (Migrate run-make/dep-graph to rmake.rs #126517)
dep-info, dep-info-spaces, dep-info-doesnt-run-much (Coalesce dep-info, dep-info-spaces and dep-info-doesnt-run-much run-make tests into dep-info rmake.rs #128787)
doctests-keep-binaries (Migrate run-make/doctests-keep-binaries to new rmake.rs format #124658)
doctests-runtool (Migrate run-make/doctests-runtool to rmake #124711)
dump-ice-to-disk, panic-abort-eh_frame (Migrate dump-ice-to-disk and panic-abort-eh_frame run-make tests to rmake #127523)
duplicate-output-flavors (Migrate run-make/duplicate-output-flavors to rmake.rs #126542)
dylib-chain, rlib-chain, issue-47384, msvc-opt-minsize, test-harness (Migrate dylib-chain, rlib-chain, issue-47384, msvc-opt-minsize and test-harness run-make tests to ui/rmake #127044)
emit-named-files (Migrate run-make/emit-named-files to rmake.rs #125849)
emit-path-unhashed, emit-shared-files (Migrate emit-shared-files and emit-path-unhashed run-make tests to rmake #127335)
emit-to-stdout (Migrate emit-to-stdout run-make test to rmake #128460)
error-found-staticlib-instead-crate, output-filename-conflicts-with-directory, output-filename-overwrites-input, native-link-modifier-verbatim-rustc, native-link-modifier-verbatim-linker (Migrate error-found-staticlib-instead-crate, output-filename-conflicts-with-directory, output-filename-overwrites-input, native-link-modifier-verbatim-rustc and native-link-verbatim-linker run-make tests to rmake.rs format #126500)
exit-code (Port exit-code run-make test to use rust #121884)
extern-diff-internal-name, extern-multiple-copies, extern-multiple-copies2 (Migrate extern-diff-internal-name, extern-multiple-copies and extern-multiple-copies2 run-make tests to rmake #128102)
extern-flag-disambiguates (migrate tests/run-make/extern-flag-disambiguates to rmake #128099)
extern-flag-fun, incremental-debugger-visualizer, incremental-session-fail (Migrate extern-flag-fun, incremental-debugger-visualiser and incremental-session-fail run-make tests to rmake.rs #126490)
extern-flag-pathless, silly-file-names, metadata-dep-info, cdylib-fewer-symbols, symbols-include-type-name (Migrate extern-flag-pathless, silly-file-names, metadata-dep-info, cdylib-fewer-symbols and symbols-include-type-name run-make tests to rmake #127006)
extern-fn-reachable (port tests/run-make/extern-fn-reachable to rmake #128314)
extra-filename-with-temp-outputs, issue-85019-moved-src-dir (Migrate extra-filename-with-temp-outputs and issue-85019-moved-src-dir run-make tests to rmake #127338)
fmt-write-bloat (migrate fmt-write-bloat to rmake #128147)
foreign-double-unwind, issue-36710, foreign-exceptions (Migrate foreign-double-unwind, issue-36710 and foreign-exceptions run-make tests to rmake #127926
git_clone_sha1.sh (Remove unused script from run-make tests #129013)
glibc-staticlib-args (Migrate run-make/glibc-staticlib-args to rmake.rs #126684)
hir-tree (Port hir-tree run-make test to ui test #122448)
inaccessible-temp-dir, output-with-hyphens, issue-10971-temps-dir (Migrate inaccessible-temp-dir, output-with-hyphens and issue-10971-temps-dir run-make tests to rmake #126279)
incr-add-rust-src-component, issue-84395-lto-embed-bitcode (Migrate incr-add-rust-src-component and issue-84395-lto-embed-bitcode run-make tests to rmake #128562)
inline-always-many-cgu (Migrate run-make/inline-always-many-cgu to rmake.rs #126823)
interdependent-c-libraries, compiler-rt-works-on-mingw, incr-foreign-head-span (Migrate interdependent-c-libraries, compiler-rt-works-on-mingw and incr-foreign-head-span run-make tests to rmake #127989)
intrinsic-unreachable, sepcomp-cci-copies, sepcomp-inlining, sepcomp-separate (Rewrite intrinsic-unreachable, sepcomp-cci-copies, sepcomp-inlining and sepcomp-separate run-make tests to rmake.rs #126427)
invalid-library (Migrate run-make/invalid-library to rmake.rs #126861)
issue-7349 (Port run-make/issue-7349 to a codegen test #123474)
issue-11908 (Migrate run-make/issue-11908 to new rmake.rs format #125031)
issue-14500 (Migrate run-make/issue-14500 to new rmake.rs format #125047)
issue-14698, issue-33329, issue-107094 (Rewrite and rename issue-14698. issue-33329 and issue-107094 run-make tests to rmake or ui #127820)
issue-15460 (Migrate run make issue 15460 #125886)
issue-22131, issue-26006 (Rewrite and rename issue-22131 and issue-26006 run-make tests to rmake #127621)
issue-25581, extern-fn-with-extern-types, extern-fn-struct-passing-abi, longjmp-across-rust, static-extern-type, extern-fn-explicit-align, extern-fn-with-packed-struct, extern-fn-mangle (Migrate 8 very similar FFI run-make tests to rmake #127491)
issue-28766 (Migrate run-make/issue-28766 to rmake #125221)
issue-30063 (Migrate run-make/issue-30063 to rmake #125227)
issue-37839, track-path-dep-info, track-pgo-dep-info (Migrate issue-37839, track-path-dep-info and track-pgo-dep-info run-make tests to rmake #127378)
issue-46239 (Migrate run-make/issue-46239 to rmake #125222)
issue-47551, issue-35164, issue-69368 (Migrate and rename issue-47551, issue-35164 and issue-69368 run-make tests to rmake #127624)
issue-51671 (Migrate bin-emit-no-symbols run-make test to rmake #125787)
issue-53964 (Migrate run-make/issue-53964 to rmake #125224)
issue-64153, invalid-staticlib, no-builtins-lto (Migrate issue-64153, invalid-staticlib and no-builtins-lto run-make tests to rmake #126437)
issue-83045, rustc-macro-dep-files, env-dep-info (Migrate issue-83045, rustc-macro-dep-files and env-dep-info run-make tests to rmake #127381)
issue-83112-incr-test-moved-file, type-mismatch-same-crate-name, issue-109934-lto-debuginfo (Migrate issue-83112-incr-test-moved-file, type-mismatch-same-crate-name and issue-109934-lto-debuginfo run-make tests to rmake or ui #127538)
issue-85401-static-mir, missing-crate-dependency, unstable-flag-required (Migrate issue-85401-static-mir, missing-crate-dependency and unstable-flag-required run-make tests to rmake #127822)
issue64319 (Migrate run-make/issue64319 to rmake and rename #125215)
jobserver-error (Migrate jobserver-error run-make test to rmake #128789)
libs-through-symlinks, translation (Migrate libs-through-symlinks and translation run-make tests to rmake #129011)
libtest-json, libtest-junit (Port tests/run-make/libtest-json to tests/ui #126773, Port run-make/libtest-json and run-make/libtest-junit to rmake #129037)
link-args-order, ls-metadata, lto-readonly-lib (Migrate link-args-order, ls-metadata and lto-readonly-lib run-make tests to rmake #126095)
link-cfg, issue-88756-default-output (Migrate link-cfg and rustdoc-default-output run-make tests to rmake #128361)
link-framework (Migrate run-make/link-framework to rmake.rs #126898)
llvm-ident (Migrate run-make/llvm-ident to rmake.rs #126941)
llvm-outputs (migrate tests/run-make/llvm-outputs to use rmake.rs #126211)
lto-empty, invalid-so, issue-20626 (Migrate lto-empty, invalid-so and issue-20626 run-make tests to rmake.rs #126964)
lto-linkage-used-attr, no-duplicate-libs, pgo-gen-no-imp-symbols (Migrate lto-linkage-used-attr, no-duplicate-libs and pgo-gen-no-imp-symbols run-make tests to rmake #127990)
lto-smoke-c, link-path-order (Migrate lto-smoke-c and link-path-order run-make tests to rmake #127928)
macos-deployment-target, libtest-thread-limit (Migrate libtest-thread-limit run-make test to rmake #128507)
macos-fat-archive, manual-link, archive-duplicate-names (Migrate macos-fat-archive, manual-link and archive-duplicate-names run-make tests to rmake #127825)
manual-crate-name (Migrate run-make/manual-crate-name to rmake.rs #126064)
min-global-align, no-alloc-shim (Migrate min-global-align and no-alloc-shim run-make tests to rmake #128407)
multiple-emits (Migrate run-make/multiple-emits to rmake.rs #126186)
no-cdylib-as-rdylib (Migrate run-make/no-cdylib-as-rdylib to rmake #125104)
no-input-file (Rewrite the no-input-file.stderr test in Rust and support diff #124257)
no-intermediate-extras (Migrate run-make/no-intermediate-extras to new rmake.rs #125218)
output-type-permutations (Migrate output-type-permutations run-make test to rmake #127098)
override-aliased-flags (Migrate run-make/override-aliased-flags to rmake.rs #127041)
panic-impl-transitive (Migrate run-make/panic-impl-transitive to rmake #125146)
pass-linker-flags, pass-linker-flags-flavor, pass-linker-flags-from-dep (Migrate pass-linker-flags-flavor, pass-linker-flags-from-dep and pass-linker-flags run-make tests to rmake #127328)
pdb-buildinfo-cl-cmd, pgo-indirect-call-promotion (Migrate pdb-buildinfo-cl-cmd and pgo-indirect-call-promotion run-make tests to rmake #128363)
pdb-alt-path, mismatching-target-triples, mingw-export-call-convention (Migrate pdb-alt-path, mismatching-target-triples and mingw-export-call-convention run-make tests to rmake #126805)
pgo-branch-weights (Migrate run-make/pgo-branch-weights to rmake #125165)
pgo-gen, pgo-use, profile (Migrate pgo-gen, pgo-use and profile run-make tests to rmake.rs #126957)
pgo-gen-lto (Migrate pgo-gen-lto run-make test to rmake #128757)
pointer-auth-link-with-c, c-dynamic-rlib, c-dynamic-dylib (Migrate pointer-auth-link-with-c, c-dynamic-rlib and c-dynamic-dylib run-make tests to rmake #127872)
prefer-dylib (Migrate tests/run-make/prefer-dylib to rmake.rs #126174)
prefer-rlib (Migrate run make prefer rlib #126310)
pretty-print-to-file, pretty-print-with-dep-file, libtest-padding (Migrate pretty-print-with-dep-file, pretty-print-to-file and libtest-padding run-make tests to rmake #126995)
print-calling-conventions, print-target-list (Migrate print-target-list to rmake and print-calling-convention to ui-test #127877)
print-cfg (Port print-cfg run-make test to Rust-based rmake.rs #124473)
print-native-static-libs (Port run-make --print=native-static-libs to rmake.rs #124383)
raw-dylib-alt-calling-convention, raw-dylib-c, redundant-libs (Migrate raw-dylib-alt-calling-convention, raw-dylib-c and redundant-libs run-make tests to rmake #128107)
raw-dylib-inline-cross-dylib, raw-dylib-custom-dlltool (Migrate raw-dylib-inline-cross-dylib and raw-dylib-custom-dlltool run-make tests to rmake #127390)
remap-path-prefix, debug-assertions, emit-stack-sizes (Migrate remap-path-prefix, debug-assertions and emit-stack-sizes run-make tests to rmake #126801)
remap-path-prefix-dwarf (Migrate remap-path-prefix-dwarf run-make test to rmake #128410)
repr128-dwarf (Port repr128-dwarf run-make test to rmake #124280)
reproducible-build (Migrate reproducible-build run-make test to rmake #128456)
reproducible-build-2, stable-symbol-names (Migrate reproducible-build-2 and stable-symbol-names run-make tests to rmake #127095)
return-non-c-like-enum (Migrate run-make/return-non-c-like-enum to rmake.rs #127116)
return-non-c-like-enum-from-c, pass-non-c-like-enum-to-c, c-static-dylib, c-static-rlib, extern-fn-generic, extern-fn-with-union, lto-no-link-whole-rlib, linkage-attr-on-static, issue-28595 (Migrate 9 more very similar FFI run-make tests to rmake #127663)
rlib-format-packed-bundled-libs, native-link-modifier-bundle (Migrate rlib-format-packed-bundled-libs and native-link-modifier-bundle run-make tests to rmake #129018)
rlib-format-packed-bundled-libs-2, native-link-modifier-whole-archive, no-builtins-attribute (Migrate rlib-format-packed-bundled-libs-2, native-link-modifier-whole-archive and no-builtins-attribute run-make tests to rmake #128075)
rust-lld, rust-lld-custom-target (Port the 2 rust-lld run-make tests to rmake #123975)
rustdoc-determinism (Rewrite rustdoc-determinism test in Rust #124698)
rustdoc-error-lines (Migrate run-make/rustdoc-error-lines to new rmake.rs #124753)
rustdoc-io-error (Migrate run-make/rustdoc-io-error to rmake.rs #124807)
rustdoc-map-file (Migrate run-make/rustdoc-map-file to rmake #124837)
rustdoc-output-path (Migrate run-make/rustdoc-output-path to rmake #124888)
rustdoc-scrape-examples-invalid-expr (Migrate run-make/rustdoc-scrape-examples-invalid-expr to rmake.rs #125248)
rustdoc-scrape-examples-macros (Migrate run-make/rustdoc-scrape-examples-macros to rmake.rs #125401)
rustdoc-scrape-examples-multiple (Migrate run-make/rustdoc-scrape-examples-multiple to rmake.rs #125357)
rustdoc-scrape-examples-ordering (Migrate rustdoc scrape examples ordering #125022)
rustdoc-scrape-examples-remap (Migrate run-make/rustdoc-scrape-examples-remap to rmake.rs #125207)
rustdoc-scrape-examples-test (Migrate run-make/rustdoc-scrape-examples-test to new rmake.rs #125275)
rustdoc-scrape-examples-whitespace (Migrate run-make/rustdoc-scrape-examples-whitespace to rmake.rs #125318)
rustdoc-shared-flags (Migrate run-make/rustdoc-shared-flags to rmake #124963)
rustdoc-target-spec-json-path (Migrate rustdoc target spec json path #125071)
rustdoc-themes (Migrate run-make/rustdoc-themes to new rmake.rs #125142)
rustdoc-verify-output-files (Migrate rustdoc verify output files #125542)
rustdoc-with-out-dir-option (Migrate run-make/rustdoc-with-out-dir-option to new rmake.rs #125178)
rustdoc-with-output-option (Migrate run-make/rustdoc-with-output-dir-option to rmake.rs #125485)
rustdoc-with-short-out-dir-option (Migrate run-make/rustdoc-with-short-out-dir-option to rmake.rs #125445)
share-generics-dylib, raw-dylib-import-name-type, raw-dylib-link-ordinal, raw-dylib-stdcall-ordinal (Migrate share-generics-dylib, raw-dylib-import-name-type, raw-dylib-link-ordinal and raw-dylib-stdcall-ordinal run-make tests to rmake #128112)
short-ice (Migrate run-make/short-ice to rmake #126036)
simd-ffi (Migrate simd-ffi run-make test to rmake #128700)
split-debuginfo (Migrate split-debuginfo run-make test to rmake #128754)
static-dylib-by-default, sanitizer-dylib-link, sanitizer-cdylib-link, sanitizer-staticlib-link (Migrate static-dylib-by-default, sanitizer-dylib-link, sanitizer-cdylib-link and sanitizer-staticlib-link run-make tests to rmake #128079)
static-unwinding (Migrate run-make/static-unwinding to rmake #125213)
staticlib-blank-lib, rlib-format-packed-bundled-libs-3, issue-97463-abi-param-passing (Migrate staticlib-blank-lib, rlib-format-packed-bundled-libs-3 and issue-97463-abi-param-passing run-make tests to rmake #127778)
staticlib-dylib-linkage (Migrate staticlib-dylib-linkage run-make test to rmake #128696)
std-core-cycle, obey-crate-type-flag, mixing-libs, issue-18943 (Migrate std-core-cycle, obey-crate-type-flag, mixing-libs and issue-18943 run-make tests to rmake.rs #126484)
stdin-non-utf8 (Add support for inputing via stdin with run-make-support #124612)
symbol-mangling-hashed ( Migrate symbol-mangling-hashed to rmake.rs #128567)
symbol-visibility (Migrate symbol-visibility run-make test to rmake #127060)
sysroot-crates-are-unstable (Port tests/run-make/sysroot-crates-are-unstable from Python to rmake #126231, Port run-make/sysroot-crates-are-unstable to rmake #129071)
target-cpu-native, target-specs, target-without-atomic-cas (Migrate target-cpu-native, target-specs and target-without-atomic-cas run-make tests to rmake #127325)
test-benches, c-unwind-abi-catch-panic, compiler-lookup-paths-2 (Migrate test-benches, c-unwind-abi-catch-panic and compiler-lookup-paths-2 run-make tests to rmake #127985)
thumb-none-cortex-m (migrate thumb-none-cortex-m to rmake #128636)
thumb-none-qemu (migrate thumb-none-qemu to rmake #128639)
~~tools.mk~~ (should be removed)
use-suggestions-rust-2018, overwrite-input, lto-dylib-dep, many-crates-but-no-match (Migrate use-suggestions-rust-2018, overwrite-input, lto-dylib-dep and many-crates-but-no-match run-make tests to rmake #127000)
used (Migrate run-make/used to rmake.rs #125988)
valid-print-requests (Improve diagnostic for unknown --print request #124333)
version (Rewrite version test run-make as an UI test #123563)
volatile-intrinsics, weird-output-filenames, wasm-override-linker, wasm-exceptions-nostd (Migrate volatile-intrinsics, weird-output-filenames, wasm-override-linker, wasm-exceptions-nostd to rmake #126880)
wasm-abi, wasm-custom-section, wasm-custom-sections-opt, wasm-export-all-symbols, wasm-import-module, wasm-panic-small, wasm-spurious-import, wasm-stringify-ints-small, wasm-symbols-different-module, wasm-symbols-not-exported, wasm-symbols-not-imported (Test wasm32-wasip1 in CI, not wasm32-unknown-unknown #122036)
x86_64-fortanix-unknown-sgx-lvi (Migrate x86_64-fortanix-unknown-sgx-lvi run-make test to rmake #129055)
emit, mixing-formats, bare-outfile (Rewrite emit, mixing-formats and bare-outfile run-make tests in rmake.rs format #125383)
core-no-oom-handling, issue-24445, issue-38237 (Rewrite core-no-oom-handling, issue-24445 and issue-38237 run-make tests to new rmake.rs format #125421)
issue-85441, windows-binary-no-external-deps, windows-safeseh, windows-spawn, windows-subsystem (Use rmake for windows- run-make tests #125613)
lto-smoke, simple-rlib, mixing-deps (Rewrite lto-smoke, simple-rlib and mixing-deps run-make tests in rmake.rs format #125638)
fpic, simple-dylib, issue-37893 (Rewrite fpic, simple-dylib and issue-37893 run-make tests in rmake.rs or ui test format #125662)
suspicious-library, resolve-rename, incr-prev-body-beyond-eof (Rewrite suspicious-library, resolve-rename and incr-prev-body-beyond-eof run-make tests in rmake.rs format #125683)
link-arg, link-dedup, issue-26092 (Migrate link-arg, link-dedup and issue-26092 run-make tests to rmake format #125500)
symlinked-extern, symlinked-rlib, symlinked-libraries (Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format #125674)
separate-link, separate-link-fail and allocator-shim-circular-deps (Rewrite separate-link, separate-link-fail and allocator-shim-circular-deps run-make tests to ui or rmake #126607)
extern-flag-rename-transitive, debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution, forced-unwind-terminate-pof (Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake #126644)
unknown-mod-stdin, issue-68794-textrel-on-minimal-lib, raw-dylib-cross-compilation, used-cdylib-macos (Migrate unknown-mod-stdin, issue-68794-textrel-on-minimal-lib, raw-dylib-cross-compilation and used-cdylib-macos run-make tests to rmake #126698)
include_bytes_deps, optimization-remarks-dir-pgo, optimization-remarks-dir, issue-40535, rmeta-preferred (Migrate include_bytes_deps, optimization-remarks-dir-pgo, optimization-remarks-dir, issue-40535 and rmeta-preferred run-make tests to rmake #126709)
relocation-model, error-writing-dependencies, crate-name-priority (Migrate relocation-model, error-writing-dependencies and crate-name-priority run-make tests to rmake #126712)
relro-levels, static-pie (Migrate relro-levels, static-pie to rmake #126715)

The text was updated successfully, but these errors were encountered:

Rewrite `core-no-fp-fmt-parse` test in Rust Claiming the simple "core-no-fp-fmt-parse" test from rust-lang#121876. `run_make_support` was altered with `arg_path` written in rust-lang#121918 by `@abhay-51,` with additional doc comment. Preliminary GSoC contribution for the project proposal mentored by `@jieyouxu.`

Rollup merge of rust-lang#123180 - Oneirical:master, r=Mark-Simulacrum Rewrite `core-no-fp-fmt-parse` test in Rust Claiming the simple "core-no-fp-fmt-parse" test from rust-lang#121876. `run_make_support` was altered with `arg_path` written in rust-lang#121918 by `@abhay-51,` with additional doc comment. Preliminary GSoC contribution for the project proposal mentored by `@jieyouxu.`

Port hir-tree run-make test to ui test As part of rust-lang#121876 cc `@jieyouxu`

Rollup merge of rust-lang#122448 - high-cloud:move-hir-tree, r=oli-obk Port hir-tree run-make test to ui test As part of rust-lang#121876 cc `@jieyouxu`

…e-enum, r=Mark-Simulacrum Port argument-non-c-like-enum to Rust Part of rust-lang#121876.

…imulacrum Port `run-make/issue-7349` to a codegen test The test does not need to be a run-make test, it can use the codegen test infrastructure. Also took the opportunity to rename the test to `no-redundant-item-monomorphization` so it's not just some opaque issue number. Part of rust-lang#121876.

Rollup merge of rust-lang#123474 - jieyouxu:issue-7349-port, r=Mark-Simulacrum Port `run-make/issue-7349` to a codegen test The test does not need to be a run-make test, it can use the codegen test infrastructure. Also took the opportunity to rename the test to `no-redundant-item-monomorphization` so it's not just some opaque issue number. Part of rust-lang#121876.

Rollup merge of rust-lang#123149 - jieyouxu:rmake-arguments-non-c-like-enum, r=Mark-Simulacrum Port argument-non-c-like-enum to Rust Part of rust-lang#121876.

…jieyouxu Migrate `libtest-thread-limit` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try, but **only if normal CI is green**: try-job: aarch64-apple try-job: aarch64-gnu

…eyouxu Migrate `libtest-thread-limit` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try, but **only if normal CI is green**: try-job: aarch64-apple try-job: aarch64-gnu

…r=jieyouxu Migrate `x86_64-fortanix-unknown-sgx-lvi` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). The final Makefile! Every Makefile test is now claimed. This is difficult to test due to the uncommon architecture it is specific to. I don't think it is in the CI (I didn't find it in `jobs.yml`, but if there is a way to test it, please do. Locally, on Linux, it compiles and panics at the `llvm_filecheck` part (if I replace the `x86_64-fortanix-unknown-sgx` with `x86_64-unknown-linux-gnu`, of course), which is expected. For this reason, the Makefile and associated script have been kept, but with a leading underscore.

Rollup merge of rust-lang#129055 - Oneirical:fortanix-fortification, r=jieyouxu Migrate `x86_64-fortanix-unknown-sgx-lvi` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). The final Makefile! Every Makefile test is now claimed. This is difficult to test due to the uncommon architecture it is specific to. I don't think it is in the CI (I didn't find it in `jobs.yml`, but if there is a way to test it, please do. Locally, on Linux, it compiles and panics at the `llvm_filecheck` part (if I replace the `x86_64-fortanix-unknown-sgx` with `x86_64-unknown-linux-gnu`, of course), which is expected. For this reason, the Makefile and associated script have been kept, but with a leading underscore.

…eyouxu Migrate `libtest-thread-limit` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try, but **only if normal CI is green**: // try-job: armhf-gnu // <- failed on this try-job: aarch64-gnu

…jieyouxu Migrate `libtest-thread-limit` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try, but **only if normal CI is green**: // try-job: armhf-gnu // <- failed on this try-job: aarch64-gnu

…eyouxu Migrate `libtest-thread-limit` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try, but **only if normal CI is green**: // try-job: armhf-gnu // <- failed on this try-job: aarch64-gnu

…ouxu Add `needs-unwind` compiletest directive to `libtest-thread-limit` and replace some `Path` with `path` in `run-make` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This PR does two things: 1. Add this to `libtest-thread-limit` ([Why?](rust-lang#128507 (comment))) ``` //@ needs-unwind // Reason: this should be ignored in cg_clif (Cranelift) CI and anywhere // else that uses panic=abort. ``` 2. Use `path` instead of `Path` to simplify multiple run-make tests.

Rollup merge of rust-lang#129690 - Oneirical:run-make-tidbits, r=jieyouxu Add `needs-unwind` compiletest directive to `libtest-thread-limit` and replace some `Path` with `path` in `run-make` Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This PR does two things: 1. Add this to `libtest-thread-limit` ([Why?](rust-lang#128507 (comment))) ``` //@ needs-unwind // Reason: this should be ignored in cg_clif (Cranelift) CI and anywhere // else that uses panic=abort. ``` 2. Use `path` instead of `Path` to simplify multiple run-make tests.

jieyouxu mentioned this issue Mar 1, 2024

Switch run-make tests from Makefiles to rust #40713

Open

4 tasks