-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pass-linker-flags-flavor
, pass-linker-flags-from-dep
and pass-linker-flags
run-make
tests to rmake
#127328
Conversation
This PR modifies cc @jieyouxu |
@bors delegate+ (for try jobs only) |
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
@bors try |
Migrate `pass-linker-flags-flavor`, `pass-linker-flags-from-dep` and `pass-linker-flags` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please test on i686-msvc. Expected to fail. try-job: i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
Migrate `pass-linker-flags-flavor`, `pass-linker-flags-from-dep` and `pass-linker-flags` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please test on i686-msvc. Expected to fail. try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
85aaaee
to
9f994b6
Compare
@rustbot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ rollup=iffy |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@bors r+ rollup=iffy |
…eyouxu Migrate `pass-linker-flags-flavor`, `pass-linker-flags-from-dep` and `pass-linker-flags` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please test on i686-msvc. Expected to fail. try-job: aarch64-apple
💔 Test failed - checks-actions |
@bors r- |
That does not seem related to this PR at all:
Could it be spurious? Would it be worthwhile to try again without changes? @rustbot review |
We've been having spurious perm issues on windows, it's not ur changes, u can try again |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d4a6200): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 5.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 701.545s -> 705.089s (0.51%) |
Part of #121876 and the associated Google Summer of Code project.
Please test on i686-msvc. Expected to fail.
try-job: aarch64-apple