-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stablize anonymous pipe #137793
Stablize anonymous pipe #137793
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This PR modifies cc @jieyouxu The Miri subtree was changed cc @rust-lang/miri |
Rolling the original libs reviewer for the other stabilization attempt. |
Please squash the commits |
791a3fd
to
57bdbe6
Compare
Some changes occurred in src/tools/cargo cc @ehuss |
(Some unintentional submodule changes I think) |
This comment has been minimized.
This comment has been minimized.
The CI error is not related to any changes in this PR:
|
#135822 also did some refactoring, are you also planning to put that up? If you do it in a separate PR feel free to request a review from me and we can probably merge it pretty quick. |
Yes I want to put it in separate PR, I hope this PR can merge quick and hope that debian could pick it up, so that jobserver/etc can use it to reduce their burden |
8acff46
to
7acb0e3
Compare
Reverted submodules changes, and tidy passed locally, so CI should be fixed now |
cc @joboet this pr is ready for review |
LGTM |
Can we get this PR merged please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have the same request as in the original PR:
The changes here look good to me, though I'd like to see another change before stabilization:
Currently, things like the
Stdio: From<PipeWriter>
implementations live insys::
which IMHO is really confusing and dangerous (because people will forget to add these implementations when portingstd
). Could you move all the public trait implementations toio::pipe
(andos::_::pipe
for the platform-specific implementations)?
Thanks, will investigate it in 1-2d |
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
9a91f4f
to
6863a99
Compare
I have fixed the error on wasm32-wasip1 by building for it locally It would be great if someone can configure the CI to run the tests for that target to verify that |
@bors try |
…<try> Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various
☀️ Try build successful - checks-actions |
@rustbot ready |
Rollup of 9 pull requests Successful merges: - rust-lang#136355 (Add `*_value` methods to proc_macro lib) - rust-lang#137621 (Add std support to cygwin target) - rust-lang#137793 (Stablize anonymous pipe) - rust-lang#138341 (std: Mention clone-on-write mutation in Arc<T>) - rust-lang#138517 (Improve upvar analysis for deref of child capture) - rust-lang#138584 (Update Rust Foundation links in Readme) - rust-lang#138586 (Document `#![register_tool]`) - rust-lang#138590 (Flatten and simplify some control flow 🫓) - rust-lang#138592 (update change entry for rust-lang#137147) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#137793 - NobodyXu:stablise-annoymous-pipe, r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closes rust-lang#127154 try-job: test-various
still in the queue after being merged @bors r- |
Since #135822 is staled, I create this PR to stablise anonymous pipe
Closes #127154
try-job: test-various