Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate raw-dylib-inline-cross-dylib and raw-dylib-custom-dlltool run-make tests to rmake #127390

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Migrate raw-dylib-inline-cross-dylib and raw-dylib-custom-dlltool run-make tests to rmake #127390

merged 2 commits into from
Jul 17, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 5, 2024 •
edited
Loading

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: i686-mingw

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@jieyouxu

This comment was marked as resolved.

Sign in to view
@jieyouxu jieyouxu mentioned this pull request Jul 6, 2024
Open
@jieyouxu

This comment was marked as resolved.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Jul 6, 2024

@bors delegate+ (for try job)

@bors
Copy link
Contributor

bors commented Jul 6, 2024

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

jieyouxu
jieyouxu approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me if try jobs come back green.

tests/run-make/raw-dylib-inline-cross-dylib/Makefile
Comment on lines -7 to -9
# We'd be using the llvm-objdump instead of the system objdump to ensure compatibility
# with the LLVM bitcode generated by rustc but on Windows piping/IO redirection under MSYS2 is wonky with llvm-objdump.
OBJDUMP = objdump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: this is cursed

@jieyouxu
Copy link
Member

jieyouxu commented Jul 6, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
@bors
Auto merge of rust-lang#127390 - Oneirical:rough-testimation, r=<try>
f91bfe2 
Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
@bors
Copy link
Contributor

bors commented Jul 6, 2024

⌛ Trying commit e705973 with merge f91bfe2...

@bors
Copy link
Contributor

bors commented Jul 6, 2024

⌛ Trying commit e705973 with merge 46897d6...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
@bors
Auto merge of rust-lang#127390 - Oneirical:rough-testimation, r=<try>
46897d6 
Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 6, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2024
@Oneirical
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2024
@bors
Auto merge of rust-lang#127390 - Oneirical:rough-testimation, r=<try>
dd352f2 
Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
@bors
Copy link
Contributor

bors commented Jul 8, 2024

⌛ Trying commit eedc1e0 with merge dd352f2...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical
Copy link
Contributor Author

Oneirical commented Jul 10, 2024 •
edited
Loading

Succeeded on x86_64 msvc, at least!
Edit: Lol. Of course it succeeded - it got ignored!
@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2024
@bors
Auto merge of rust-lang#127390 - Oneirical:rough-testimation, r=<try>
8f0e074 
Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: i686-mingw
@bors
Copy link
Contributor

bors commented Jul 10, 2024

⌛ Trying commit 8e0871a with merge 8f0e074...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 10, 2024

💔 Test failed - checks-actions

@Oneirical
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 12, 2024
@bors
Auto merge of rust-lang#127390 - Oneirical:rough-testimation, r=<try>
738f94f 
Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: i686-mingw
@bors
Copy link
Contributor

bors commented Jul 12, 2024

⌛ Trying commit ef1d03a with merge 738f94f...

@bors
Copy link
Contributor

bors commented Jul 12, 2024

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Jul 12, 2024

⌛ Trying commit b983658 with merge aae8cbb...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 12, 2024
@bors
Auto merge of rust-lang#127390 - Oneirical:rough-testimation, r=<try>
aae8cbb 
Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: i686-mingw
@bors
Copy link
Contributor

bors commented Jul 12, 2024

☀️ Try build successful - checks-actions
Build commit: aae8cbb (aae8cbb58230476deb3a927a0436dacd0b386078)

@Oneirical
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2024
jieyouxu
jieyouxu approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup=iffy (windows, and exercises custom dlltool feature)

@bors
Copy link
Contributor

bors commented Jul 16, 2024

📌 Commit b983658 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024
@tgross35 tgross35 mentioned this pull request Jul 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2024
@bors
Auto merge of rust-lang#127831 - tgross35:rollup-c0j9n7b, r=tgross35
7d356eb 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#124033 (Sync ar_archive_writer to LLVM 18.1.3)
 - rust-lang#126699 (Delegation: support coercion for target expression)
 - rust-lang#126762 (Deny keyword lifetimes pre-expansion)
 - rust-lang#126967 (Promote the `wasm32-wasip2` target to Tier 2)
 - rust-lang#127390 (Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake)
 - rust-lang#127501 (Invert infer `error_reporting` mod struture)
 - rust-lang#127816 (Update method name to reflect changes to its internals)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d18a741 into rust-lang:master Jul 17, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2024
@rust-timer
Unrolled build for rust-lang#127390
a101953 
Rollup merge of rust-lang#127390 - Oneirical:rough-testimation, r=jieyouxu

Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: i686-mingw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Oneirical @rustbot @jieyouxu @bors @rust-log-analyzer