-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate run-make/allow-warnings-cmdline-stability
to rmake.rs
#125573
Migrate run-make/allow-warnings-cmdline-stability
to rmake.rs
#125573
Conversation
Some changes occurred in run-make tests. cc @jieyouxu |
@rustbot author |
470bac6
to
5588ca5
Compare
The run-make-support library was changed cc @jieyouxu |
@rustbot ready |
let output = rustc().input("foo.rs").arg("-Awarnings").command_output(); | ||
|
||
assert!(output.status.success()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I think this can be run()
instead of command_output()
, because run()
provided by impl_common_helpers!(Rustc)
is
/// Run the constructed command and assert that it is successfully run.
#[track_caller]
pub fn run(&mut self) -> ::std::process::Output {
let caller_location = ::std::panic::Location::caller();
let caller_line_number = caller_location.line();
let output = self.command_output();
if !output.status.success() {
handle_failed_output(&self.cmd, output, caller_line_number);
}
output
}
i.e. just
let output = rustc().input("foo.rs").arg("-Awarnings").run();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the output
below to get stdout
and stderr
. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, nevermind. Yes you're absolutely right, good catch!
Thanks, one suggestion then r=me. |
5588ca5
to
c2dd262
Compare
Thanks! @bors r+ rollup |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#125339 (The number of tests does not depend on the architecture's pointer width) - rust-lang#125539 (crashes: increment the number of tracked ones) - rust-lang#125542 (Migrate rustdoc verify output files) - rust-lang#125613 (Use `rmake` for `windows-` run-make tests) - rust-lang#125616 (MIR validation: ensure that downcast projection is followed by field projection) Failed merges: - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#125339 (The number of tests does not depend on the architecture's pointer width) - rust-lang#125542 (Migrate rustdoc verify output files) - rust-lang#125616 (MIR validation: ensure that downcast projection is followed by field projection) - rust-lang#125625 (Use grep to implement verify-line-endings) Failed merges: - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup
☔ The latest upstream changes (presumably #125628) made this pull request unmergeable. Please resolve the merge conflicts. |
c2dd262
to
404d47e
Compare
@bors r=jieyouxu rollup |
…ngs-cmdline-stability, r=jieyouxu Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#117671 (NVPTX: Avoid PassMode::Direct for args in C abi) - rust-lang#124251 (Add an intrinsic for `ptr::metadata`) - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`) - rust-lang#125590 (Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable) - rust-lang#125598 (Make `ProofTreeBuilder` actually generic over `Interner`) - rust-lang#125637 (rustfmt fixes) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#117671 (NVPTX: Avoid PassMode::Direct for args in C abi) - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`) - rust-lang#125590 (Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable) - rust-lang#125598 (Make `ProofTreeBuilder` actually generic over `Interner`) - rust-lang#125637 (rustfmt fixes) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125573 - GuillaumeGomez:migrate-allow-warnings-cmdline-stability, r=jieyouxu Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs` Part of rust-lang#121876. r? ``@jieyouxu``
Part of #121876.
r? @jieyouxu