-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate and rename issue-47551
, issue-35164
and issue-69368
run-make
tests to rmake
#127624
Conversation
This comment has been minimized.
This comment has been minimized.
cd94394
to
51e47b4
Compare
@bors delegate+ (for try jobs only) |
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
@bors try |
Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: dist-riscv64-linux try-job: test-various try-job: x86-64-msvc
This comment has been minimized.
This comment has been minimized.
@bors try |
Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: dist-riscv64-linux try-job: test-various try-job: x86_64-msvc
@rustbot author (please flip to review when ready) |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
51e47b4
to
ae68b28
Compare
This PR modifies cc @jieyouxu The run-make-support library was changed cc @jieyouxu |
ae68b28
to
0dd0170
Compare
@bors try |
Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc
This comment has been minimized.
This comment has been minimized.
Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-mingw try-job: x86_64-gnu-llvm-18 try-job: i686-msvc try-job: aarch64-apple try-job: test-various try-job: armhf-gnu
Rollup of 8 pull requests Successful merges: - rust-lang#127567 (std: implement the `once_wait` feature) - rust-lang#127624 (Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake) - rust-lang#128162 (Cleanup sys module to match house style) - rust-lang#128437 (improve bootstrap to allow selecting llvm tools individually) - rust-lang#128443 (Properly mark loop as diverging if it has no breaks) - rust-lang#128449 (Temporarily switch `ambiguous_negative_literals` lint to allow) - rust-lang#128450 (Create COFF archives for non-LLVM backends) - rust-lang#128452 (derive(SmartPointer): require pointee to be maybe sized) r? `@ghost` `@rustbot` modify labels: rollup
Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-mingw try-job: x86_64-gnu-llvm-18 try-job: i686-msvc try-job: aarch64-apple try-job: test-various try-job: armhf-gnu
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
This seems to have nothing to do with the test? Not to mention that it passed a bunch of try-jobs before, including MSVC. Let's see if it's spurious. @bors try |
Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-msvc
☀️ Try build successful - checks-actions |
💡 This pull request was already approved, no need to approve it again.
|
Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: dist-x86_64-msvc
Rollup of 5 pull requests Successful merges: - rust-lang#123994 (Use Default visibility for rustc-generated C symbol declarations) - rust-lang#126818 (Better handle suggestions for the already present code and fix some suggestions) - rust-lang#127624 (Migrate and rename `issue-47551`, `issue-35164` and `issue-69368` `run-make` tests to rmake) - rust-lang#128361 (Migrate `link-cfg` and `rustdoc-default-output` `run-make` tests to rmake) - rust-lang#128436 (Update sysinfo version to 0.31.2) r? `@ghost` `@rustbot` modify labels: rollup
☀️ Test successful - checks-actions |
Finished benchmarking commit (425ae69): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 758.235s -> 757.745s (-0.06%) |
Part of #121876 and the associated Google Summer of Code project.
try-job: dist-x86_64-msvc