Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate run-make/multiple-emits to rmake.rs #126186

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

GuillaumeGomez
Copy link
Member

Part of #121876.

r? @jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 9, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

tests/run-make/multiple-emits/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/multiple-emits/rmake.rs Outdated Show resolved Hide resolved
@Kobzol Kobzol added the A-run-make Area: port run-make Makefiles to rmake.rs label Jun 9, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Jun 9, 2024

Yeah, sorry for the support library changes :3 I'll try to draft up some docs for the support library to help test writers navigate and work with the support library later today/tomorrow to hopefully make this less painful.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024
@GuillaumeGomez GuillaumeGomez force-pushed the migrate-run-make-multiple-emits branch from 927b889 to e8b04cc Compare June 11, 2024 12:09
@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2024

The run-make-support library was changed

cc @jieyouxu

@GuillaumeGomez
Copy link
Member Author

Added the path function as suggested and fixed the test code.

@bors ready

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately bors is not ready 😆

Thanks for the fixes, feel free to r=me after CI is green!

@Kobzol
Copy link
Contributor

Kobzol commented Jun 11, 2024

@bors r=jieyouxu

(Wanted to approve this, but jieyouxu got here first, so I r'd it :) ).

@bors
Copy link
Contributor

bors commented Jun 11, 2024

📌 Commit e8b04cc has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#126186 (Migrate `run-make/multiple-emits` to `rmake.rs`)
 - rust-lang#126236 (Delegation: fix ICE on recursive delegation)
 - rust-lang#126254 (Remove ignore-cross-compile directive from ui/macros/proc_macro)
 - rust-lang#126258 (Do not define opaque types when selecting impls)
 - rust-lang#126265 (interpret: ensure we check bool/char for validity when they are used in a cast)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dea5237 into rust-lang:master Jun 11, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
Rollup merge of rust-lang#126186 - GuillaumeGomez:migrate-run-make-multiple-emits, r=jieyouxu

Migrate `run-make/multiple-emits` to `rmake.rs`

Part of rust-lang#121876.

r? `@jieyouxu`
@GuillaumeGomez GuillaumeGomez deleted the migrate-run-make-multiple-emits branch June 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants