-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change config.toml to bootstrap.toml #137081
base: master
Are you sure you want to change the base?
change config.toml to bootstrap.toml #137081
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
Failed to set assignee to
|
r? @onur-ozkan |
This comment has been minimized.
This comment has been minimized.
044bdca
to
58f42a6
Compare
39f2c36
to
e4506e0
Compare
Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in src/tools/compiletest cc @jieyouxu This PR modifies If appropriate, please update Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. This PR modifies cc @jieyouxu Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb This PR modifies If appropriate, please update Some changes occurred in src/doc/unstable-book/src/compiler-flags/control-flow-guard.md cc @rust-lang/project-exploit-mitigations, @rcvalle Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/opt-dist cc @Kobzol Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol Some changes occurred in match checking cc @Nadrieril |
This looks like a rebase gone wild? You might try |
3c592fd
to
6b86aae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bootstrap changes seems good to me
6b86aae
to
2f99cbf
Compare
2f99cbf
to
7aeea28
Compare
☔ The latest upstream changes (presumably #137176) made this pull request unmergeable. Please resolve the merge conflicts. |
7aeea28
to
9e9ad4f
Compare
☔ The latest upstream changes (presumably #137346) made this pull request unmergeable. Please resolve the merge conflicts. |
Currently, both Bootstrap and Cargo uses same name as their configuration file, which can be confusing. This PR is based on a discussion to rename
config.toml
tobootstrap.toml
for Bootstrap. Closes: #126875.I have split the PR into atomic commits to make it easier to review. Once the changes are finalized, I will squash them. I am particularly concerned about the changes made to modules that are not part of Bootstrap. How should we handle those changes? Should we ping the respective maintainers?