-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate run-make/link-framework
to rmake.rs
#126898
Migrate run-make/link-framework
to rmake.rs
#126898
Conversation
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
2cb3bda
to
dd7d6b0
Compare
Fixed fmt. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's try if it works on Apple.
@bors try
@bors try |
…-framework, r=<try> Migrate `run-make/link-framework` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #127956) made this pull request unmergeable. Please resolve the merge conflicts. |
dd7d6b0
to
4b8f12b
Compare
@bors try |
…-framework, r=<try> Migrate `run-make/link-framework` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
4b8f12b
to
d0d137b
Compare
@bors try |
…-framework, r=<try> Migrate `run-make/link-framework` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: x86_64-apple-1
☀️ Try build successful - checks-actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one nit, otherwise LGTM. You can r=me after removing the unnecessary variables.
d0d137b
to
e8e6111
Compare
@bors r+ |
…nk-framework, r=Kobzol Migrate `run-make/link-framework` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol` try-job: x86_64-apple-1
Rollup of 7 pull requests Successful merges: - rust-lang#124895 (Disallow hidden references to mutable static) - rust-lang#125834 (treat `&raw (const|mut) UNSAFE_STATIC` implied deref as safe) - rust-lang#126898 (Migrate `run-make/link-framework` to `rmake.rs`) - rust-lang#127962 (Cleanup compiletest dylib name calculation) - rust-lang#127990 (Migrate `lto-linkage-used-attr`, `no-duplicate-libs` and `pgo-gen-no-imp-symbols` `run-make` tests to rmake) - rust-lang#128067 (Get rid of `can_eq_shallow`) - rust-lang#128076 (Get rid of `InferCtxtExt` from `error_reporting::traits`) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#125886 (Migrate run make issue 15460) - rust-lang#126898 (Migrate `run-make/link-framework` to `rmake.rs`) - rust-lang#126994 (Support lists and stylings in more places for `rustc --explain`) - rust-lang#127990 (Migrate `lto-linkage-used-attr`, `no-duplicate-libs` and `pgo-gen-no-imp-symbols` `run-make` tests to rmake) - rust-lang#128060 (Fix inclusion of `wasm-component-ld` in dist artifacts) - rust-lang#128082 (Note closure captures when reporting cast to fn ptr failed) - rust-lang#128098 (make it possible to disable download-rustc if it's incompatible) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#126898 - GuillaumeGomez:migrate-run-make-link-framework, r=Kobzol Migrate `run-make/link-framework` to `rmake.rs` Part of rust-lang#121876. r? ``@Kobzol`` try-job: x86_64-apple-1
Part of #121876.
r? @Kobzol
try-job: x86_64-apple-1