-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate run make const fn mir #126270
Migrate run make const fn mir #126270
Conversation
This PR modifies cc @jieyouxu The run-make-support library was changed cc @jieyouxu |
// If we can bless (meaning we have a file to write into and the `RUSTC_BLESS_TEST` | ||
// environment variable set), then we write into the file and return. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take note to also write this into the support library docs, we probably also should document this in rustc-dev-guide for run-make tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose so. Didn't know there was a guide. ^^'
@rustbot author |
14bcf0c
to
f8ecd1c
Compare
For the dev guide, I'll need to send a PR to the target repository so nothing I can do here directly. Applied suggestion for the test. @bors ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one suggestion about using fs_wrapper
, then r=me after CI is green.
(Also bors doesn't know about ready, only rustbot does 😆)
Too many bots. 😅 |
f8ecd1c
to
60ce260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This comment has been minimized.
This comment has been minimized.
60ce260
to
1336292
Compare
Not sure why it failed in the GCC backend. Rebased, let's see if it's happy now. |
This comment has been minimized.
This comment has been minimized.
1336292
to
5f4111f
Compare
@bors r=jieyouxu rollup |
…nst_fn_mir, r=jieyouxu Migrate run make const fn mir Part of rust-lang#121876. r? `@jieyouxu`
…nst_fn_mir, r=jieyouxu Migrate run make const fn mir Part of rust-lang#121876. r? ``@jieyouxu``
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#124884 (place explicit lifetime bound after generic param) - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1) - rust-lang#126270 (Migrate run make const fn mir) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126368 (Remove some unnecessary crate dependencies.) - rust-lang#126386 (Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`) - rust-lang#126449 (Fill out missing Windows support information) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1) - rust-lang#126270 (Migrate run make const fn mir) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126449 (Fill out missing Windows support information) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#126270 - GuillaumeGomez:migrate-run-make-const_fn_mir, r=jieyouxu Migrate run make const fn mir Part of rust-lang#121876. r? ```@jieyouxu```
@@ -0,0 +1,8 @@ | |||
// The `needs-unwind -Cpanic=abort` gives a different MIR output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been //@ needs-unwind
. # needs-unwind
in Makefile tests ignores the test when -Cpanic=abort
is the default, like with cg_clif or when compiling for wasm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked around this in rust-lang/rustc_codegen_cranelift@e241176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, fixing it and reverting your mir changes as well.
…ion, r=bjorn3 Add `run-make/const_fn_mir` missing test annotation Fixes comment from rust-lang#126270. r? `@bjorn3`
Rollup merge of rust-lang#126580 - GuillaumeGomez:add-missing-annotation, r=bjorn3 Add `run-make/const_fn_mir` missing test annotation Fixes comment from rust-lang#126270. r? `@bjorn3`
Part of #121876.
r? @jieyouxu