place explicit lifetime bound after generic param #124884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
May 8, 2024
bvanjoi
force-pushed
the
fix-124785
branch
2 times, most recently
from
c3a73dc to
58b918f
Compare
estebank
reviewed
May 20, 2024
estebank
reviewed
May 20, 2024
tests/ui/generic-associated-types/static-lifetime-tip-with-default-type.rs
Show resolved
Hide resolved
estebank
reviewed
May 20, 2024
estebank
reviewed
May 24, 2024
| .params | ||
| .iter() | ||
| .find(|param| param.def_id == def_id) | ||
| .unwrap(); |
There was a problem hiding this comment.
I'm mildly concerned about this unwrap() and would prefer if we instead used if let for this, but I can't think of a case where a Param from another item might end up here.
There was a problem hiding this comment.
Yep, the Self item will cause a panic when using unwrap, but it has been handled in other branches. Anyway, I will use if let for added safety.
estebank
reviewed
May 24, 2024
Comment on lines
+2402
to
+2401
| let span = self.tcx.def_span(def_id); | ||
| span.shrink_to_hi() |
There was a problem hiding this comment.
Out of curiosity, is there any case where this can be reached?
There was a problem hiding this comment.
I also think no cases can reach this branch, but using unreachable!() here seems unnecessary...
estebank
reviewed
May 24, 2024
|
Let me know if you have time to address the nitpick. |
|
@bors r+ |
|
🌲 The tree is currently closed for pull requests below priority 13. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 14, 2024
place explicit lifetime bound after generic param Fixes rust-lang#124785 An easy fix.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#124884 (place explicit lifetime bound after generic param) - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1) - rust-lang#126270 (Migrate run make const fn mir) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126368 (Remove some unnecessary crate dependencies.) - rust-lang#126386 (Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`) - rust-lang#126449 (Fill out missing Windows support information) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124884 (place explicit lifetime bound after generic param) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126368 (Remove some unnecessary crate dependencies.) - rust-lang#126386 (Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
Rollup merge of rust-lang#124884 - bvanjoi:fix-124785, r=estebank place explicit lifetime bound after generic param Fixes rust-lang#124785 An easy fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124785
An easy fix.