Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #126463

Merged
merged 12 commits into from
Jun 14, 2024
Merged

Rollup of 5 pull requests #126463

merged 12 commits into from
Jun 14, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

bvanjoi and others added 12 commits May 25, 2024 21:57
Since we support solaris 11 and macOs Sierra as minimum, we can get rid
of the runtime overhead.
place explicit lifetime bound after generic param

Fixes rust-lang#124785

An easy fix.
Remove some msys2 utils

`dos2unix` should no longer be necessary. I suspect `diffutils` might not be needed either as (I think) only `diff` is used and that seems to be shipped with git bash at least.

try-job: x86_64-msvc
try-job: x86_64-msvc-ext
try-job: dist-x86_64-msvc
std::unix::fs::link using direct linkat call for Solaris.

Since we support solaris 11 as minimum, we can get rid of the runtime overhead.

try-job: dist-various-2
…eps, r=jackh726

Remove some unnecessary crate dependencies.

A follow-up to rust-lang#126063.

r? ``@jackh726``
…low-non-lint-warnings-cmdline, r=jieyouxu

Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`

Part of rust-lang#121876.

r? ```@jieyouxu```
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 14, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jun 14, 2024

📌 Commit edd4c97 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2024
@bors
Copy link
Contributor

bors commented Jun 14, 2024

⌛ Testing commit edd4c97 with merge 63491e1...

@bors
Copy link
Contributor

bors commented Jun 14, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 63491e1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2024
@bors bors merged commit 63491e1 into rust-lang:master Jun 14, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 14, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#124884 place explicit lifetime bound after generic param cd50baa34015d03f622f7c0587ec982e9c988452 (link)
#126343 Remove some msys2 utils fc78627aedb9793a64c2989d9df2e3b0ab47899b (link)
#126351 std::unix::fs::link using direct linkat call for Solaris. 3170c5a1faad31caa476dd1051041fc4b01a7c6c (link)
#126368 Remove some unnecessary crate dependencies. 86346e7ee4b773af48aac56a24c49a78070f7596 (link)
#126386 Migrate run-make/allow-non-lint-warnings-cmdline to `rmak… d23df7b78594f69218c45bce0ec74235cee8dbc8 (link)

previous master: d2ad293851

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (63491e1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 671.82s -> 670.246s (-0.23%)
Artifact size: 320.39 MiB -> 320.41 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-lnkfibf branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants