Rollup of 8 pull requests #124703

matthiaskrgr · 2024-05-04T10:37:25Z

Successful merges:

Reduce code size of thread::set_current #123356 (Reduce code size of thread::set_current)
Move thread parking to sys::sync #124159 (Move thread parking to sys::sync)
Let miri and const eval execute intrinsics' fallback bodies #124293 (Let miri and const eval execute intrinsics' fallback bodies)
Set non-leaf frame pointers on Fuchsia targets #124677 (Set non-leaf frame pointers on Fuchsia targets)
We do not coerce &mut &mut T -> *mut mut T #124692 (We do not coerce &mut &mut T -> *mut mut T)
Rewrite rustdoc-determinism test in Rust #124698 (Rewrite rustdoc-determinism test in Rust)
Remove an unnecessary cast #124700 (Remove an unnecessary cast)
Docs: suggest uN::checked_sub instead of check-then-unchecked #124701 (Docs: suggest uN::checked_sub instead of check-then-unchecked)

r? @ghost
@rustbot modify labels: rollup

…to preserve all UB that the native intrinsic would have

Very minor thing, obviously, but I randomly saw this unnecessary cast showing up in the UbChecks, so might as well get rid of it.

As of 124114 it's exactly the same in codegen, so might as well not use `unsafe`. Note that this is only for *unsigned*, since the overflow conditions for `iN::checked_sub` are more complicated.

…nton Reduce code size of `thread::set_current` rust-lang#123265 introduced a rather large binary size regression, because it added an `unwrap()` call on a `Result<(), Thread>`, which in turn pulled its rather heavy `Debug` implementation. This PR fixes this by readding the `rtassert!` that was removed.

…ChrisDenton Move thread parking to `sys::sync` Part of rust-lang#117276. I'll leave the platform-specific API abstractions in `sys::pal`, as per the initial proposal. I'm not entirely sure whether we'll want to keep it that way, but that remains to be seen. r? ``@ChrisDenton`` (if you have time)

…dy, r=RalfJung Let miri and const eval execute intrinsics' fallback bodies fixes rust-lang/miri#3397 r? ``@RalfJung``

…r, r=tmandry Set non-leaf frame pointers on Fuchsia targets This is part of our work to enable shadow call stack sanitization on Fuchsia, see [this Fuchsia issue](https://g-issues.fuchsia.dev/issues/327643884). r? ``@tmandry``

…pointer-coercion-happens, r=compiler-errors We do not coerce `&mut &mut T -> *mut mut T` Resolves rust-lang#34117 by declaring it to be "working as intended" until someone RFCs it or whatever other lang proposal would be required. It seems a bit of a footgun, but perhaps there are strong reasons to allow it anyways. Seeing as how I often have to be mindful to not allow a pointer to coerce the wrong way in my FFI work, I am inclined to think not, but perhaps it's fine in some use-case and that's actually more common?

…m, r=jieyouxu Rewrite `rustdoc-determinism` test in Rust Rewrite the `rustdoc-determinism` test from rust-lang#121876. r? `@jieyouxu`

Remove an unnecessary cast Very minor thing, obviously, but I randomly saw this unnecessary cast showing up in the UbChecks, so might as well get rid of it.

…strieb Docs: suggest `uN::checked_sub` instead of check-then-unchecked As of rust-lang#124114 it's exactly the same in codegen, so might as well not use `unsafe`. Note that this is only for *unsigned*, since the overflow conditions for `iN::checked_sub` are more complicated.

matthiaskrgr · 2024-05-04T10:37:41Z

@bors r+ rollup=never p=8

bors · 2024-05-04T10:37:44Z

📌 Commit 5f4f4fb has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-05-04T12:41:44Z

⌛ Testing commit 5f4f4fb with merge d7ea278...

bors · 2024-05-04T14:49:33Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d7ea278 to master...

rust-timer · 2024-05-04T14:51:47Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#123356	Reduce code size of `thread::set_current`	`cbb447828058be53cc8875aeb3e6a7330c48cf89` (link)
#124159	Move thread parking to `sys::sync`	`4616c6780e17fd541f77561f567bacd2e43433c7` (link)
#124293	Let miri and const eval execute intrinsics' fallback bodies	`c46f24d997bd3c0244c1fd5391dea2ffb5b95b5f` (link)
#124677	Set non-leaf frame pointers on Fuchsia targets	`e35f1bcedd204c5f8069d20fc36d1ff6256dd8fa` (link)
#124692	We do not coerce `&mut &mut T -> *mut mut T`	`c8fbad0bff067c2e0751543935ef423189188623` (link)
#124698	Rewrite `rustdoc-determinism` test in Rust	`2b43de0c4b3d22d4c292a28ee559d36c118e1d51` (link)
#124700	Remove an unnecessary cast	`f19ee876fb8440aa7d13616e8f4e64f550b98df6` (link)
#124701	Docs: suggest `uN::checked_sub` instead of check-then-unche…	`610131609b9f20c7a0297cd5dc947c4cffd7c9ef` (link)

previous master: 7dd170fccb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-05-04T16:05:29Z

Finished benchmarking commit (d7ea278): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 0.6%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.5%, -0.5%]	4
All ❌✅ (primary)	0.5%	[0.2%, 0.6%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	5.7%	[0.4%, 12.4%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-5.6%, -1.6%]	4
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	2
All ❌✅ (primary)	2.3%	[-5.6%, 12.4%]	10

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.2%, -2.0%]	3
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.0%, 1.5%]	62
Regressions ❌ (secondary)	0.2%	[0.1%, 0.2%]	4
Improvements ✅ (primary)	-0.5%	[-1.2%, -0.0%]	11
Improvements ✅ (secondary)	-0.4%	[-1.2%, -0.2%]	46
All ❌✅ (primary)	0.3%	[-1.2%, 1.5%]	73

Bootstrap: 676.427s -> 674.772s (-0.24%)
Artifact size: 315.91 MiB -> 315.91 MiB (0.00%)

Kobzol · 2024-05-04T18:24:28Z

@rust-timer build c46f24d

rust-timer · 2024-05-04T20:48:25Z

Finished benchmarking commit (c46f24d): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-1.5%, -0.4%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.427s -> 676.947s (0.08%)
Artifact size: 315.91 MiB -> 315.88 MiB (-0.01%)

Kobzol · 2024-05-04T20:56:29Z

@rust-timer build cbb4478

rust-timer · 2024-05-05T00:31:19Z

Finished benchmarking commit (cbb4478): comparison URL.

Overall result: ✅ improvements - no action needed

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.4%	[-4.4%, -4.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.4%	[-4.4%, -4.4%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.5%, -2.2%]	6
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-1.2%, -0.0%]	12
Improvements ✅ (secondary)	-0.3%	[-1.2%, -0.2%]	37
All ❌✅ (primary)	-0.5%	[-1.2%, -0.0%]	12

Bootstrap: 676.427s -> 675.889s (-0.08%)
Artifact size: 315.91 MiB -> 315.87 MiB (-0.01%)

Kobzol · 2024-05-05T07:50:40Z

Seems to be caused by #124700 (comment), which probably just modified some inlining decisions. The regression on image has swinged back immediately, and the rest of the regressions are small. Marking as triaged.

@rustbot label: +perf-regression-triaged

joboet and others added 20 commits April 2, 2024 11:41

std: reduce code size of set_current

e7b5730

std: add comment about abort motivation

061d873

std: update abort message in thread::set_current

37c1758

std: move thread parking to sys::sync

a56fd37

Let miri and const eval execute intrinsics' fallback bodies

351658a

Ensure miri only uses fallback bodies that have manually been vetted …

821d23b

…to preserve all UB that the native intrinsic would have

Set non-leaf frame pointers on Fuchsia targets

0637709

We do not coerce &mut &mut T -> *mut mut T

e404e7a

mark const_(de)allocate intrinsics as suitable for Miri

4e97c6c

Rewrite rustdoc-determinism test in Rust

2f4861c

Remove an unnecessary cast

b95d1b7

Very minor thing, obviously, but I randomly saw this unnecessary cast showing up in the UbChecks, so might as well get rid of it.

Docs: suggest uN::checked_sub instead of check-then-unchecked

e1c833e

As of 124114 it's exactly the same in codegen, so might as well not use `unsafe`. Note that this is only for *unsigned*, since the overflow conditions for `iN::checked_sub` are more complicated.

Rollup merge of rust-lang#124293 - oli-obk:miri_intrinsic_fallback_bo…

ceb7b5e

…dy, r=RalfJung Let miri and const eval execute intrinsics' fallback bodies fixes rust-lang/miri#3397 r? ``@RalfJung``

Rollup merge of rust-lang#124698 - JoverZhang:test-rustdoc-determinis…

b871137

…m, r=jieyouxu Rewrite `rustdoc-determinism` test in Rust Rewrite the `rustdoc-determinism` test from rust-lang#121876. r? `@jieyouxu`

Rollup merge of rust-lang#124700 - scottmcm:unneeded_cast, r=Nilstrieb

7705671

Remove an unnecessary cast Very minor thing, obviously, but I randomly saw this unnecessary cast showing up in the UbChecks, so might as well get rid of it.

rustbot added the rollup A PR which is a rollup label May 4, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label May 4, 2024

bors merged commit d7ea278 into rust-lang:master May 4, 2024
7 checks passed

rustbot added this to the 1.80.0 milestone May 4, 2024

This was referenced May 4, 2024

Miri subtree update #124709

Closed

Rollup of 5 pull requests #124710

Closed

rustbot added the perf-regression Performance regression. label May 4, 2024

This comment has been minimized.

Sign in to view

scottmcm mentioned this pull request May 4, 2024

Remove an unnecessary cast #124700

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label May 5, 2024

matthiaskrgr deleted the rollup-2lljptd branch September 1, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #124703

Rollup of 8 pull requests #124703

matthiaskrgr commented May 4, 2024

matthiaskrgr commented May 4, 2024

bors commented May 4, 2024

bors commented May 4, 2024

bors commented May 4, 2024

rust-timer commented May 4, 2024

rust-timer commented May 4, 2024

Kobzol commented May 4, 2024

This comment has been minimized.

rust-timer commented May 4, 2024

Kobzol commented May 4, 2024

This comment has been minimized.

rust-timer commented May 5, 2024

Kobzol commented May 5, 2024

Rollup of 8 pull requests #124703

Rollup of 8 pull requests #124703

Conversation

matthiaskrgr commented May 4, 2024

matthiaskrgr commented May 4, 2024

bors commented May 4, 2024

bors commented May 4, 2024

bors commented May 4, 2024

rust-timer commented May 4, 2024

rust-timer commented May 4, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Kobzol commented May 4, 2024

This comment has been minimized.

rust-timer commented May 4, 2024

Overall result: ❌✅ regressions and improvements - no action needed

Kobzol commented May 4, 2024

This comment has been minimized.

rust-timer commented May 5, 2024

Overall result: ✅ improvements - no action needed

Kobzol commented May 5, 2024