Skip to content

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 20, 2024

close #36010
close #68667
close #74938
close #83585
close #93036
close #109328
close #110797
close #111508
close #112509
close #113757
close #120440
close #118392
close #71096

r? nikic

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@fmease fmease changed the title Add codegen tests for E-needtest Add codegen tests for E-needs-test May 21, 2024
@tesuji
Copy link
Contributor Author

tesuji commented Jun 5, 2024

Reassinging r? cuviper

@rustbot rustbot assigned cuviper and unassigned nikic Jun 5, 2024
@rust-log-analyzer

This comment has been minimized.

@tesuji
Copy link
Contributor Author

tesuji commented Jun 8, 2024

I pushed new changes. Only 1adf495 commit is interesting, all others are just rebased on master.

@tesuji
Copy link
Contributor Author

tesuji commented Jun 9, 2024

Rebased on #126173

Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more nits...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jun 11, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2024
@tesuji
Copy link
Contributor Author

tesuji commented Jun 11, 2024

I thought CHECK-NEXT: [pattern] is kinda like line.starts_with(pattern).
Anyway, changed from CHECK-NEXT: ret to CHECK-NEXT: retq.

@nikic
Copy link
Contributor

nikic commented Jun 11, 2024

I thought CHECK-NEXT: [pattern] is kinda like line.starts_with(pattern). Anyway, changed from CHECK-NEXT: ret to CHECK-NEXT: retq.

It is. The problem is not the retq, but that apple platforms have a popq %rbp before it, so CHECK-NEXT does not work.

@tesuji
Copy link
Contributor Author

tesuji commented Jun 11, 2024

Well, I guess ABI of x86-apple is different from the others on x86-linux and windows.

@nikic
Copy link
Contributor

nikic commented Jun 13, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 13, 2024

📌 Commit ab0f87e has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2024
@bors
Copy link
Collaborator

bors commented Jun 13, 2024

⌛ Testing commit ab0f87e with merge 4936869...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
.......... (120/124)
...F       (124/124)


/checkout/tests/rustdoc-gui/help-page.goml help-page... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` line 16
    from `tests/rustdoc-gui/help-page.goml` line 23
    from `tests/rustdoc-gui/help-page.goml` line 32: Error: Evaluation failed: The following errors happened: [localStorage item "rustdoc-theme" (of value "ayu") != "null"]: for command `assert-local-storage: {"rustdoc-theme": |theme|}`
Error: ()
Build completed unsuccessfully in 0:03:50
  local time: Thu Jun 13 20:28:02 UTC 2024
  network time: Thu, 13 Jun 2024 20:28:02 GMT

@bors
Copy link
Collaborator

bors commented Jun 13, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 13, 2024
@cuviper
Copy link
Member

cuviper commented Jun 13, 2024

#126430

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2024
@bors
Copy link
Collaborator

bors commented Jun 14, 2024

⌛ Testing commit ab0f87e with merge 7ac6c2f...

@bors
Copy link
Collaborator

bors commented Jun 14, 2024

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 7ac6c2f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2024
@bors bors merged commit 7ac6c2f into rust-lang:master Jun 14, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 14, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7ac6c2f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.7% [-3.8%, 2.5%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.938s -> 671.574s (0.09%)
Artifact size: 320.39 MiB -> 319.78 MiB (-0.19%)

@tesuji tesuji deleted the needtests branch June 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment