Make async drop code more consistent with regular drop code #126594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
PG-exploit-mitigations
|
Some changes occurred in compiler/rustc_sanitizers cc @rust-lang/project-exploit-mitigations, @rcvalle |
|
Couldn't reproduce the linking error using std, only reproduced with simple |
|
r? @oli-obk |
|
☔ The latest upstream changes (presumably #126605) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
reviewed
Jun 18, 2024
oli-obk
reviewed
Jun 18, 2024
oli-obk
reviewed
Jun 18, 2024
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
zetanumbers
force-pushed
the
fix-cross-crate-async-drop-glue
branch
from
023acf6
to
1a8eae1
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 18, 2024
…drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? `@petrochenkov`
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jun 19, 2024
…drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? ``@petrochenkov``
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jun 19, 2024
…drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? ```@petrochenkov```
This was referenced Jun 19, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#123782 (Test that opaque types can't have themselves as a hidden type with incompatible lifetimes) - rust-lang#124580 (Suggest removing unused tuple fields if they are the last fields) - rust-lang#125787 (Migrate `bin-emit-no-symbols` `run-make` test to `rmake`) - rust-lang#126553 (match lowering: expand or-candidates mixed with candidates above) - rust-lang#126594 (Make async drop code more consistent with regular drop code) - rust-lang#126654 (Make pretty printing for `f16` and `f128` consistent) - rust-lang#126656 (rustc_type_ir: Omit some struct fields from Debug output) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2024
Rollup merge of rust-lang#126594 - zetanumbers:fix-cross-crate-async-drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? ````@petrochenkov````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126573
Relates to #126482
r? @petrochenkov