Rename fuchsia builder and bump Fuchsia #127102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the quality-of-life improvements for developers in https://fxrev.dev/1061894.
This should no longer be required to build Fuchsia.
This better reflects what the builder actually does.
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
A-testsuite
|
r? rust-lang/infra @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 28, 2024
Rename fuchsia builder and bump Fuchsia This PR renames the fuchsia builder as requested in rust-lang/rustc-dev-guide#1989 (review) and bumps Fuchsia. It also removes the wasm target, which should speed up the build a little. The new name of the builder is `x86_64-fuchsia` because I think `x86_64-gnu-fuchsia` would be confusing and put too much emphasis on the host target. (In terms of triples, we are targeting `x86_64-unknown-fuchsia` from `x86_64-unknown-linux-gnu`.) Someone on the infra team should weigh in here. cc `@lqd` r? t-infra try-job: x86_64-fuchsia
|
Hehe we wanted to do it in #127023 |
|
Ah, I'm fine with landing that one first then :) |
|
☀️ Try build successful - checks-actions |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#126822 (Bootstrap command refactoring: port more `Command` usages to `BootstrapCmd` (step 2)) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126953 (std: separate TLS key creation from TLS access) - rust-lang#127045 (Rename `super_predicates_of` and similar queries to `explicit_*` to note that they're not elaborated) - rust-lang#127075 (rustc_data_structures: Explicitly check for 64-bit atomics support) - rust-lang#127101 (remove redundant match statement from dataflow const prop) - rust-lang#127102 (Rename fuchsia builder and bump Fuchsia) - rust-lang#127103 (Move binder and polarity parsing into `parse_generic_ty_bound`) - rust-lang#127108 (unify `dylib` and `bin_helpers` and create `shared_helpers::parse_value_from_args`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2024
Rollup merge of rust-lang#127102 - tmandry:rename-fuchsia-builder, r=Kobzol Rename fuchsia builder and bump Fuchsia This PR renames the fuchsia builder as requested in rust-lang/rustc-dev-guide#1989 (review) and bumps Fuchsia. This includes the quality-of-life improvements for developers in https://fxrev.dev/1061894. It also removes the wasm target, which should speed up the build a little. The new name of the builder is `x86_64-fuchsia` because I think `x86_64-gnu-fuchsia` would be confusing and put too much emphasis on the host target. (In terms of triples, we are targeting `x86_64-unknown-fuchsia` from `x86_64-unknown-linux-gnu`.) Someone on the infra team should weigh in here. After this lands, we should update the docs in the rustc-dev-guide again. cc `@lqd` r? t-infra try-job: x86_64-fuchsia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the fuchsia builder as requested in rust-lang/rustc-dev-guide#1989 (review) and bumps Fuchsia.
This includes the quality-of-life improvements for developers in https://fxrev.dev/1061894. It also removes the wasm target, which should speed up the build a little.
The new name of the builder is
x86_64-fuchsiabecause I thinkx86_64-gnu-fuchsiawould be confusing and put too much emphasis on the host target. (In terms of triples, we are targetingx86_64-unknown-fuchsiafromx86_64-unknown-linux-gnu.) Someone on the infra team should weigh in here.After this lands, we should update the docs in the rustc-dev-guide again.
cc @lqd
r? t-infra
try-job: x86_64-fuchsia