Rollup of 9 pull requests #127111
Merged
Rollup of 9 pull requests #127111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was obtained by repeatedly inlining and simplifying.
This commit too was obtained by repeatedly inlining and simplifying.
Currently, `std` performs an atomic load to get the OS key on every access to `StaticKey` even when the key is already known. This PR thus replaces `StaticKey` with the platform-specific `get` and `set` function and a new `LazyKey` type that acts as a `LazyLock<Key>`, allowing the reuse of the retreived key for multiple accesses.
Instead of keeping a list of architectures which have native support for 64-bit atomics, just use #[cfg(target_has_atomic = "64")] and its inverted counterpart to determine whether we need to use portable AtomicU64 on the target architecture.
This will make it easier to migrate existing commands to bootstrap command.
By allowing `run` to receive all of `BootstrapCmd`, `&mut BootstrapCmd`, `Command` and `&mut Command`.
This includes the quality-of-life improvements for developers in https://fxrev.dev/1061894.
This should no longer be required to build Fuchsia.
This better reflects what the builder actually does.
remove redundant match statement from dataflow const prop
…Kobzol Rename fuchsia builder and bump Fuchsia This PR renames the fuchsia builder as requested in rust-lang/rustc-dev-guide#1989 (review) and bumps Fuchsia. This includes the quality-of-life improvements for developers in https://fxrev.dev/1061894. It also removes the wasm target, which should speed up the build a little. The new name of the builder is `x86_64-fuchsia` because I think `x86_64-gnu-fuchsia` would be confusing and put too much emphasis on the host target. (In terms of triples, we are targeting `x86_64-unknown-fuchsia` from `x86_64-unknown-linux-gnu`.) Someone on the infra team should weigh in here. After this lands, we should update the docs in the rustc-dev-guide again. cc `@lqd` r? t-infra try-job: x86_64-fuchsia
…d-parsing, r=fmease Move binder and polarity parsing into `parse_generic_ty_bound` Let's pull out the parts of rust-lang#127054 which just: 1. Make the parsing code less confusing 2. Fix `?use<>` (to correctly be denied) 3. Improve `T: for<'a> 'a` diagnostics This should have no user-facing effects on stable parsing. r? fmease
unify `dylib` and `bin_helpers` and create `shared_helpers::parse_value_from_args` `dylib` and `bin_helpers` were already used in similar logic. This PR unifies them under a `shared_helpers` module that is utilized by both the bootstrap library and shims. Additionally, created `parse_value_from_args` with a unit test. This helps avoid code duplication in shims and can also be used in the bootstrap library if needed (which is the case in one of `@Kobzol's` tasks). r? `@Kobzol`
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 38d0f87a49 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jun 29, 2024
|
Finished benchmarking commit (be99243): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 693.672s -> 699.052s (0.78%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Commandusages toBootstrapCmd(step 2) #126822 (Bootstrap command refactoring: port moreCommandusages toBootstrapCmd(step 2))super_predicates_ofand similar queries toexplicit_*to note that they're not elaborated #127045 (Renamesuper_predicates_ofand similar queries toexplicit_*to note that they're not elaborated)parse_generic_ty_bound#127103 (Move binder and polarity parsing intoparse_generic_ty_bound)dylibandbin_helpersand createshared_helpers::parse_value_from_args#127108 (unifydylibandbin_helpersand createshared_helpers::parse_value_from_args)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup