match lowering: Move MatchPair tree creation to its own module
#127709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to see that `MatchPair::new` has only one non-recursive caller, because the recursive callers are all in this module.
|
rustbot has assigned @matthewjasper. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in match lowering cc @Nadrieril |
|
r? @Nadrieril |
|
Nice, this is indeed clearer. Thank you! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#120990 (Suggest a borrow when using dbg) - rust-lang#127047 (fix least significant digits of f128 associated constants) - rust-lang#127709 (match lowering: Move `MatchPair` tree creation to its own module) - rust-lang#127770 (Update books) - rust-lang#127780 (Make sure trait def ids match before zipping args in `note_function_argument_obligation`) - rust-lang#127795 (Fix typos in RELEASES.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
Rollup merge of rust-lang#127709 - Zalathar:pair-mod, r=Nadrieril match lowering: Move `MatchPair` tree creation to its own module This makes it easier to see that `MatchPair::new` has only one non-recursive caller, because the recursive callers are all in this module. No functional changes. --- I have used `git diff --color-moved` to verify that the moved code is identical to the old code, except for reduced visibility on the helper methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to see that
MatchPair::newhas only one non-recursive caller, because the recursive callers are all in this module. No functional changes.I have used
git diff --color-movedto verify that the moved code is identical to the old code, except for reduced visibility on the helper methods.