Make sure trait def ids match before zipping args in note_function_argument_obligation
#127780
+98
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Jul 15, 2024
This comment has been minimized.
This comment has been minimized.
…gument_obligation
compiler-errors
force-pushed
the
zip-args
branch
from
c16e9a5 to
841b30f
Compare
|
@bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 15, 2024
Make sure trait def ids match before zipping args in `note_function_argument_obligation` Fixes rust-lang#126416 Fixes rust-lang#127745 Didn't add both tests b/c I felt like it was unnecessary.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 15, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#120990 (Suggest a borrow when using dbg) - rust-lang#127047 (fix least significant digits of f128 associated constants) - rust-lang#127629 (Suggest using `map_or` when `Option<&T>::unwrap_or where T: Deref` fails) - rust-lang#127770 (Update books) - rust-lang#127780 (Make sure trait def ids match before zipping args in `note_function_argument_obligation`) r? `@ghost` `@rustbot` modify labels: rollup
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 16, 2024
Make sure trait def ids match before zipping args in `note_function_argument_obligation` Fixes rust-lang#126416 Fixes rust-lang#127745 Didn't add both tests b/c I felt like it was unnecessary.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#120990 (Suggest a borrow when using dbg) - rust-lang#127047 (fix least significant digits of f128 associated constants) - rust-lang#127680 (Bootstrap command refactoring: port remaining commands with access to `Build` (step 6)) - rust-lang#127770 (Update books) - rust-lang#127780 (Make sure trait def ids match before zipping args in `note_function_argument_obligation`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#120990 (Suggest a borrow when using dbg) - rust-lang#127047 (fix least significant digits of f128 associated constants) - rust-lang#127709 (match lowering: Move `MatchPair` tree creation to its own module) - rust-lang#127770 (Update books) - rust-lang#127780 (Make sure trait def ids match before zipping args in `note_function_argument_obligation`) - rust-lang#127795 (Fix typos in RELEASES.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2024
Rollup merge of rust-lang#127780 - compiler-errors:zip-args, r=jieyouxu Make sure trait def ids match before zipping args in `note_function_argument_obligation` Fixes rust-lang#126416 Fixes rust-lang#127745 Didn't add both tests b/c I felt like it was unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126416
Fixes #127745
Didn't add both tests b/c I felt like it was unnecessary.