Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #127892

Merged
merged 31 commits into from
Jul 18, 2024
Merged

Rollup of 9 pull requests #127892

merged 31 commits into from
Jul 18, 2024

Commits on Jul 16, 2024

  1. Remove an unnecessary ?.

    nnethercote committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2f305ff View commit details
    Browse the repository at this point in the history
  2. Inline Parser::parse_item_common_.

    It has a single call site, it isn't that big, and its name is
    confusingly similar to `Parser::parse_item_common`.
    nnethercote committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    48cdfc3 View commit details
    Browse the repository at this point in the history
  3. Reorder Parser::parse_expr_dot_or_call_with arguments.

    Put `attrs` before `e0` because that matches the order in the source
    code, where outer attributes appear before expressions.
    nnethercote committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d247489 View commit details
    Browse the repository at this point in the history
  4. Inline and remove Parser::parse_and_disallow_postfix_after_cast.

    It has a single call site. Removing it removes the need for an
    `ExprKind` check. The commit also clarifies the relevant comment.
    nnethercote committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    96cc9c9 View commit details
    Browse the repository at this point in the history
  5. Inline and remove Parser::parse_expr_dot_or_call_with_.

    It only has two call sites, and it extremely similar to
    `Parser::parse_expr_dot_or_call_with`, in both name and behaviour. The
    only difference is the latter has an `attrs` argument and an
    `ensure_sufficient_stack` call. We can pass in an empty `attrs` as
    necessary, as is already done at some `parse_expr_dot_or_call_with` call
    sites.
    nnethercote committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    96b39f1 View commit details
    Browse the repository at this point in the history
  6. Fix a comment.

    nnethercote committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8cb6bc3 View commit details
    Browse the repository at this point in the history
  7. Remove references to maybe_whole_expr.

    It was removed in rust-lang#126571.
    nnethercote committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9c4f3db View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    17c70a9 View commit details
    Browse the repository at this point in the history
  2. unix: stack_start_aligned is a safe fn

    This function is purely informative, answering where a stack starts.
    This is a safe operation, even if an answer requires unsafe code,
    and even if the result is some unsafe code decides to trust the answer.
    It also doesn't need to fetch the PAGE_SIZE when its caller just did so!
    Let's complicate its signature and in doing so simplify its operation.
    
    This allows sprinkling around #[forbid(unsafe_op_in_unsafe_fn)]
    workingjubilee committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e285c95 View commit details
    Browse the repository at this point in the history
  3. unix: clean up install_main_guard_freebsd

    This just was a mess.
    workingjubilee committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6ed563d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d47cb26 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    21dc49c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f9c0d33 View commit details
    Browse the repository at this point in the history
  7. Document the column numbers for the dbg! macro

    The line numbers were also made consistent, some examples used the line numbers as shown on the playground while others used the line numbers that you would expect when just seeing the documentation.
    The second option was chosen to make everything consistent.
    Kriskras99 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    99f879c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1d40d4c View commit details
    Browse the repository at this point in the history
  9. Commonize uname -m results for aarch64 in docker runner

    `uname -m` on Linux reports `aarch64`, but on MacOS reports `arm64`.
    Commonize this to `aarch64`.
    
    With this fix, it is now possible to run aarch64 CI docker images on Arm
    MacOS.
    tgross35 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f3f0b57 View commit details
    Browse the repository at this point in the history
  10. Unignore cg_gcc fmt

    GuillaumeGomez committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e1852d0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    261d92c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    12bedc3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    213782d View commit details
    Browse the repository at this point in the history
  14. Add support for literals

    c410-f3r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    553279b View commit details
    Browse the repository at this point in the history
  15. style-guide: Clarify version-sorting

    Every time we apply version-sorting, we also say to sort non-lowercase before
    lowercase. This seems likely to be what we'll want for future sorting,
    as well. For simplicity, just incorporate that into the definition,
    "unless otherwise specified".
    joshtriplett committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    37257b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Rollup merge of rust-lang#127542 - c410-f3r:concat-again, r=petrochenkov

    [`macro_metavar_expr_concat`] Add support for literals
    
    Adds support for literals in macro parameters.
    
    ```rust
    macro_rules! with_literal {
        ($literal:literal) => {
            const ${concat(FOO, $literal)}: i32 = 1;
        }
    }
    
    fn main() {
        with_literal!("_BAR");
        assert_eq!(FOO_BAR, 1);
    }
    ```
    
    cc rust-lang#124225
    
    r? ``@petrochenkov``
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e6f0caf View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#127652 - GuillaumeGomez:cg-gcc-fmt, r=Urgau

    Unignore cg_gcc fmt
    
    `rustc_codegen_gcc` uses `rustfmt` now so it can be unignored.
    
    r? ``@Urgau``
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    973d92c View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#127664 - compiler-errors:precise-capturing-…

    …better-sugg-apit, r=oli-obk
    
    Fix precise capturing suggestion for hidden regions when we have APITs
    
    Suggests to turn APITs into type parameters so they can be named in precise capturing syntax for hidden type lifetime errors. We also note that it may change the API.
    
    This is currently done via a note *and* a suggestion, which feels a bit redundant, but I wasn't totally sure of a better alternative for the presentation.
    
    Code is kind of a mess but there's a lot of cases to consider. Happy to iterate on this if you think the approach is too messy.
    
    Based on rust-lang#127619, only the last commit is relevant.
    r? oli-obk
    
    Tracking:
    
    - rust-lang#123432
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b5771e7 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#127806 - nnethercote:parser-improvements, r…

    …=spastorino
    
    Some parser improvements
    
    I was looking closely at attribute handling in the parser while debugging some issues relating to rust-lang#124141, and found a few small improvements.
    
    ``@spastorino``
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    fa13036 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#127828 - tgross35:docker-aarch64-uname, r=o…

    …nur-ozkan
    
    Commonize `uname -m` results for `aarch64` in docker runner
    
    `uname -m` on Linux reports `aarch64`, but on MacOS reports `arm64`. Commonize this to `aarch64`.
    
    With this fix, it is now possible to run aarch64 CI docker images on Arm MacOS.
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d76ec07 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#127845 - workingjubilee:actually-break-up-b…

    …ig-ass-stack-overflow-fn, r=joboet
    
    unix: break `stack_overflow::install_main_guard` into smaller fn
    
    This was one big deeply-indented function for no reason. This made it hard to reason about the boundaries of its safety. Or just, y'know, read. Simplify it by splitting it into platform-specific functions, but which are still asked to keep compiling (a desirable property, since all of these OS use a similar API).
    
    This is mostly a whitespace change, so I suggest reviewing it only after setting Files changed -> (the options gear) -> [x] Hide whitespace as that will make it easier to see how the code was actually broken up instead of raw line diffs.
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3c4f820 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#127859 - RalfJung:ptr-dyn-metadata, r=scottmcm

    ptr::metadata: avoid references to extern types
    
    References to `extern types` are somewhat dubious entities, since generally we say that references must be dereferenceable for their size as determined via `size_of_val`, but with `extern type` that is an ill-defined statement. I'd like to make Miri warn for such cases since it interacts poorly with Stacked Borrows. To avoid warnings people can't fix, this requires not using references to `extern type` in the standard library, and I think `DynMetadata` is the only currently remaining use. so this changes `DynMetadata` to use a NonNull raw pointer instead. Given that the alignment was 1, this shouldn't really change anything meaningful.
    
    I also updated a comment added by `@scottmcm` in rust-lang#125479, since I think the old comment is wrong. The `DynMetadata` type itself is not special, it is a normal aggregate. But computing field types for wide pointers (including references) is special.
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c36a39c View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#127861 - Kriskras99:patch-1, r=tgross35

    Document the column numbers for the dbg! macro
    
    The line numbers were also made consistent, some examples used the line numbers as shown on the playground while others used the line numbers that you would expect when just seeing the documentation.
    
    The second option was chosen to make everything consistent.
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8bb0578 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#127875 - joshtriplett:style-guide-clarify-s…

    …orting, r=compiler-errors
    
    style-guide: Clarify version-sorting
    
    Every time we apply version-sorting, we also say to sort non-lowercase before
    lowercase. This seems likely to be what we'll want for future sorting,
    as well. For simplicity, just incorporate that into the definition,
    "unless otherwise specified".
    tgross35 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7c63526 View commit details
    Browse the repository at this point in the history