fix: explain E0120 better cover cases when its raised

[princess-entrapta]

Fixes #98996

Wording change on the explain of E0120 as requested

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[tgross35]

Thanks for the PR! While you're touching this file, mind updating the last example?

rust/compiler/rustc_error_codes/src/error_codes/E0120.md

Lines 27 to 33 in 3d68afc

	Alternatively, wrapping trait objects requires something:
	```
	trait MyTrait {}
	//or Box<MyTrait>, if you wanted an owned trait object
	struct MyWrapper<'a> { foo: &'a MyTrait }

Few changes there:

1. It should be &'a dyn MyTrait nowadays, and Box<dyn MyTrait> in the comment
2. "Alternatively, wrapping trait objects requires something" is pretty imprecise. I think just "Alternatively, Drop can be implemented on trait objects:" works, no need to explain what trait objects are (they are a lot easier to identify since dyn)
3. Space between // and or

[tgross35]

@rustbot author

[tgross35]

Also you can add "Fixes #98996" to your PR description to automatically close that when this gets merged.

[tgross35]

Thanks! Add the backticks and squash into one commit please, then lgtm

[tgross35]

And tidy failed, so these lines need a rewrap lol https://github.com/rust-lang/rust/actions/runs/10005456061/job/27656226565?pr=127949#step:25:1676 (you can run ./x test tidy to check locally). Thanks for updating this about 15 times

[rustbot]

Some changes occurred in match lowering

cc @Nadrieril

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

[tgross35]

Woah, rebase gone wrong?

[tgross35]

@princess-entrapta the file itself looks good, but it seems like the git history got messed up. Maybe double check that master is up to date with the rust-lang repo (not your fork) and then rebase again. If these extra commits show up on your local history, you might just be able to drop them during rebase.

[princess-entrapta]

Alrigrt, i check that now

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

• ab62382

[rustbot]

changes to the core type system

cc @compiler-errors, @lcnr

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

The run-make-support library was changed

cc @jieyouxu

HIR ty lowering was modified

cc @fmease

[princess-entrapta]

It took me some time, idk what i've done wrong with the rebases, but it should be good now

[tgross35]

It looks all good now. Thanks for the change!

r? @tgross35
@bors r+ rollup

[bors]

📌 Commit af7ecb6 has been approved by tgross35

It is now in the queue for this repository.