Selects a rust-toolchain declared RA based on its date. The earliest (oldest) RA wins and becomes the one that the workspace uses as a whole.

In terms of precedence:

nightly > stable-with-version > stable

With stable-with-version, we invoke the RA with a `--version` arg and attempt to extract a date. Given the same date as a nightly, the nightly RA will win.

fix: Insert a tail `Ok(())` for expr block instead of wrapping with `Ok`

Fixes rust-lang#17728

When type mismatch is `Result<(), E>, ()` or `Option<()>, ()` and target expr is a block expression, it is more reasonable to insert a wrapped unit - `Ok(())` or `Some(())` - as the tail expression of that block than wrapping the entire block with `Ok` or `Some`

feat: Use oldest rustup rust-analyzer when toolchain override is present

Selects a rust-toolchain declared RA based on its date. The earliest (oldest) RA wins and becomes the one that the workspace uses as a whole.

In terms of precedence:

nightly > stable-with-version > stable

With stable-with-version, we invoke the RA with a `--version` arg and attempt to extract a date. Given the same date as a nightly, the nightly RA will win.

Fixes rust-lang#17663

… at once

internal: Remove AbsPathBuf::TryFrom impl that checks too many things at once

rust-lang/rust-analyzer#16889 (comment)

fix: Insert a generic arg for `impl Trait` when lowering generic args

Fixes rust-lang#17191

We are not inserting a generic arg when lowering generics like
```rust
fn foo<T: B<impl A>(..) { ... }
```
but when we are lowering predicates we do;

https://github.com/rust-lang/rust-analyzer/blob/aa00ddcf654a35ba0eafe17247cf189958d33182/crates/hir-ty/src/lower.rs#L1697-L1718
https://github.com/rust-lang/rust-analyzer/blob/aa00ddcf654a35ba0eafe17247cf189958d33182/crates/hir-ty/src/lower.rs#L310

and this mismatch causes index out of bound panic while substituting the predicates

feat: Load sysroot library via cargo metadata

See rust-lang#128534, fixes rust-lang/rust-analyzer#7637

Requires a toolchain from 176e545 2024-08-04 or later to work.

internal: Newtype `ErasedFileAstId`

It wrapping `la_arena::Idx` makes it quite annoying to use

feat: support inlay hint for more expr with label

follow up rust-lang/rust-analyzer#17635

docs: add msvc note to manual

Added note for Windows users to have the latest MSVC to minimize setup issues.

Closes rust-lang#4870

Split out syntax-bridge into a separate crate

This functionality is not really tied to mbe macros, so imo it has no place in that crate.

minor: Fix metrics not running

`@bors` r+

perf: Segregate syntax and semantic diagnostics

Closes rust-lang#17731

…r=Veykril

feat: Implement diagnostic for `await` outside of `async`

Closes rust-lang#17781

internal: Load VFS config changes in parallel

Simple attempt to make some progress f or rust-lang/rust-analyzer#17373
No clue if those atomic orderings are right, though I don't think they are really too relevant either.

A more complete fix would probably need to replace our `ProjectFolders` handling a bit.

internal: Reorganize debug.ts

…r=Veykril

fix: Surpress type mismatches in calls with mismatched arg counts

These tend to get very noisy, hiding the actual problem.

…package.description]` fields

…]` fields

…er` crate

With the lack of a README on the individually published library crates and the somewhat cryptic `ra_ap_` prefix it is hard to figure out where those crates belong to, so mentioning "rust-analyzer" feels like auseful hint there.

…ge.repository.workspace] = true`

fix: Panic in path transform with default type parameters

Fixes rust-lang#17578

…=Veykril

Improve crate manifests, adding missing `[package.repository]` and `[package.description]` fields

As [discussed on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/Could.20we.20add.20repository.20url.20to.20.60ra_ap_.60.20crates.20on.20crates.2Eio.3F/near/455095161).

cc `@Veykril` `@lnicola`

StaticIndex::compute filters out modules from libraries. This makes an
exceptions for vendored libraries, ie libraries actually defined inside
the workspace being indexed.

This aims to solve https://bugzilla.mozilla.org/show_bug.cgi?id=1846041
In general StaticIndex is meant for code browsers, which likely want to
index all visible source files.

…=Veykril

Allow rust-project.json to be hidden

Closes rust-lang#17816

fix: tyck for non-ADT types when searching refs for `Self` kw

See https://github.com/rust-lang/rust-analyzer/pull/15864/files/e0276dc5ddc38c65240edb408522bb869f15afb4#r1389848845

For ADTs, to handle `{error}` in generic args, we should to convert them to ADT for comparisons; for others, we can directly compare the types.

…ykril

Include vendored crates in StaticIndex

`StaticIndex::compute` filters out modules from libraries. This makes an exceptions for vendored libraries, ie libraries actually defined inside the workspace being indexed.

This aims to solve https://bugzilla.mozilla.org/show_bug.cgi?id=1846041 In general StaticIndex is meant for code browsers, which likely want to index all visible source files.

internal: Remove unnecessary CfgFlag definition in project-model

fix: Fix unconfigured diagnostic being attached to the wrong file for modules

Fixes rust-lang/rust-analyzer#17817

fix: Native diagnostics not working

              This should be a `continue` now

_Originally posted by `@Veykril` in rust-lang/rust-analyzer#17775 (comment)

I've tested the release compile output with IDE in the original PR, but my test workspace had only one `.rs` file 🤦 😢

internal: Offload diagnostics serialization to the task pool

…ntinuation, r=lnicola

Improve crate manifest of 'syntax-bridge', adding missing `[package.repository]` and `[package.description]` fields

This is a follow-up of rust-lang/rust-analyzer#17745, specifically [this comment](rust-lang/rust-analyzer#17745 (comment)) by `@lnicola.`

It refines the manifest of the newly added 'syntax-bridge' crate, adding a `[package.repository]` as `workspace = true` and changes the existing `[package.description]` from "TBD" to a more useful description.

…r, r=Veykril

internal: Move and split flycheck crate into rust-analyzer main crate

The crate no longer is about flychecking, it mainly hosts common command process handling shared by flycheck, test explorer and now project discovery. This re-organizes that into the main crate.

fix: Panic while rendering function type hint with impl trait arg

Fixes rust-lang#17811

A configurable recursion limit was introduced by looking at the
recursion_limit crate attribute. Instead of relying on a global constant
we will reuse this value for expansion limit as well.

minor: log error when sysroot can't be discovered

Closes rust-lang#17808

internal: Move some main crate stuff

fix: Fix find_path not respecting non-std preference config correctly

Fixes rust-lang/rust-analyzer#17840

feat: Implement TAIT and fix ATPIT a bit

Closes rust-lang#16296 (Commented on the issue)

In rust-lang#16852, I implemented ATPIT, but as I didn't discern ATPIT and other non-assoc TAIT, I guess that it has been working for some TAITs.

As the definining usage of TAIT requires it should be appear in the Def body's type(const blocks' type annotations or functions' signatures), this can be done in simlilar way with ATPIT

And this PR also corrects some defining-usage resolution for ATPIT

Reuse recursion limit as expansion limit

A configurable recursion limit was introduced by looking at the recursion_limit crate attribute. Instead of relying on a global constant we will reuse this value for expansion limit as well.

Addresses: rust-lang/rust-analyzer#8640 (comment)

This reverts commit 567bde603cfeedb5cfc44e441578c5416bfc4f35.

…=Veykril

fix: Correctly support `#[rustc_deprecated_safe_2024]`

Fixes rust-lang/rust-analyzer#17852