Create opaque definitions in resolver. #129493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
early-opaque-def
branch
from
c77925b to
e3f7b82
Compare
petrochenkov
added
S-waiting-on-author
cjgillot
force-pushed
the
early-opaque-def
branch
from
e3f7b82 to
db08c17
Compare
cjgillot
added
S-waiting-on-review
|
r=me after squashing. |
rustbot
added
S-waiting-on-author
cjgillot
force-pushed
the
early-opaque-def
branch
from
db08c17 to
885a6ce
Compare
cjgillot
force-pushed
the
early-opaque-def
branch
from
885a6ce to
f68f665
Compare
cjgillot
commented
Sep 1, 2024
| } | ||
| } | ||
| ExprKind::Gen(_, _, _, _) => { | ||
| ExprKind::Closure(..) | ExprKind::Gen(..) => { |
There was a problem hiding this comment.
FYI, I simplified the Closure arm to just create the def-id, like other branches do. There is no additional behaviour change.
|
@bors r=petrochenkov |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#128495 (core: use `compare_bytes` for more slice element types) - rust-lang#128641 (refactor: standardize duplicate processes in parser) - rust-lang#129207 (Lint that warns when an elided lifetime ends up being a named lifetime) - rust-lang#129493 (Create opaque definitions in resolver.) - rust-lang#129619 (Update stacker to 0.1.17) - rust-lang#129672 (Make option-like-enum.rs UB-free and portable) - rust-lang#129780 (add crashtests for several old unfixed ICEs) - rust-lang#129832 (Remove stray dot in `std::char::from_u32_unchecked` documentation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2024
Rollup merge of rust-lang#129493 - cjgillot:early-opaque-def, r=petrochenkov Create opaque definitions in resolver. Implementing rust-lang#129023 (comment) That was easier than I expected. r? `@petrochenkov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #129023 (comment)
That was easier than I expected.
r? @petrochenkov