Lint that warns when an elided lifetime ends up being a named lifetime (`elided_named_lifetimes`) #129207

GrigorenkoPV · 2024-08-17T19:12:10Z

As suggested in #48686 (comment)

Fixes #48686

compiler/rustc_resolve/src/late.rs

compiler/rustc_hir/src/def.rs

rustbot · 2024-08-23T19:58:01Z

rustc_errors::translation was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

GrigorenkoPV · 2024-08-23T20:00:23Z

rustc_errors::translation was changed

replaced some elided lifetimes with explicit ones

Some changes occurred in src/tools/clippy

replaced some elided lifetimes with explicit ones
blessed some tests, because there is a new lint

The Miri subtree was changed

replaced some elided lifetimes with explicit ones

cjgillot · 2024-08-24T15:20:41Z

Could you submit d214d0b as a standalone PR? Is can be merged while we review this PR.

cjgillot · 2024-08-24T17:38:59Z

Thanks!

As for the matter with crate_node_id, it will prevent users from controlling lint behaviour using allow/deny attributes. The missing node-ids are those which correspond to a ElidedAnchor resolution.

2 alternative ideas:

channel the correct NodeId for the lint to use;
emit the lints when seeing the ElidedAnchor in record_lifetime_res.

…times, r=cjgillot Fix `elided_named_lifetimes` in code rust-lang#129207 (comment) r? cjgillot

GrigorenkoPV · 2024-08-24T21:30:38Z

As for the matter with crate_node_id, it will prevent users from controlling lint behaviour using allow/deny attributes. The missing node-ids are those which correspond to a ElidedAnchor resolution.

Ah, I was worried that it might cause some sort of a problem, and indeed it does. Oh well. I seem to have fixed it and I also added a test for this.

compiler/rustc_resolve/src/late.rs

compiler/rustc_resolve/src/late/diagnostics.rs

compiler/rustc_resolve/src/late.rs

GrigorenkoPV · 2024-08-24T22:49:51Z

@rustbot author

Due to a change in Rust nightly, the Rust linter now warns when an elided lifetime ends up being a named lifetime [1]. In this case, the elided lifetime is `'static`, so we should explicitly set the named lifetime to `'static`. [1] rust-lang/rust#129207

irbull · 2024-09-06T03:40:30Z

Part of the Deno project is built with Rust +nightly and is being hit by this change-set with the following error:

error: elided lifetime has a name
  --> core/runtime/snapshot.rs:32:19
   |
32 | ) -> (V8Snapshot, SerializableSnapshotSidecarData) {
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'static`

The fix is easy [1], but I thought I would leave this here in case others are being hit by it and hopefully google can index "elided lifetime has a name".

[1] denoland/deno_core#895

Due to a change in Rust nightly, the Rust linter now warns when an elided lifetime ends up being a named lifetime [1]. In this case, the elided lifetime is `'static`, so we should explicitly set the lifetime to `'static`. [1] rust-lang/rust#129207

GrigorenkoPV · 2024-09-06T11:05:53Z

The fix is easy

There is an upcoming PR implementing suggestions for this lint #129840. Currently it is in a conflict with some of clippy's suggestions, but maybe I can mark it non-machine-applicable for now, so that there are at least human-readable suggestions preventing confusion.

Thank you for your report!

…s-suggestion, r=cjgillot Implement suggestions for `elided_named_lifetimes` A follow-up to rust-lang#129207, as per rust-lang#129207 (comment). r? cjgillot I will probably squash this a bit, but later. `@rustbot` label +A-lint

Rollup merge of rust-lang#129840 - GrigorenkoPV:elided-named-lifetimes-suggestion, r=cjgillot Implement suggestions for `elided_named_lifetimes` A follow-up to rust-lang#129207, as per rust-lang#129207 (comment). r? cjgillot I will probably squash this a bit, but later. `@rustbot` label +A-lint

…milio This warning was introduced by rust-lang/rust#129207. Differential Revision: https://phabricator.services.mozilla.com/D221462

…milio This warning was introduced by rust-lang/rust#129207. Differential Revision: https://phabricator.services.mozilla.com/D221462 UltraBlame original commit: 22a83ceba50b60d9407cbd3afc0a620b6c5d9eed

I compile Zed from nightly build pretty often and I've noticed that we're getting a few hits on new rustc lint: rust-lang/rust#129207

I compile Zed from nightly build pretty often and I've noticed that we're getting a few hits on new rustc lint: rust-lang/rust#129207 Release Notes: - N/A

Due to a change in Rust nightly, the Rust linter now warns when an elided lifetime ends up being a named lifetime [1]. In this case, the elided lifetime is `'static`, so we should explicitly set the lifetime to `'static`. [1] rust-lang/rust#129207

I compile Zed from nightly build pretty often and I've noticed that we're getting a few hits on new rustc lint: rust-lang/rust#129207 Release Notes: - N/A

rust-lang/rust#129207 helps name certain elided lifetimes

…milio This warning was introduced by rust-lang/rust#129207. Differential Revision: https://phabricator.services.mozilla.com/D221462

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. labels Aug 17, 2024