Tweak some attributes to improve panic_immediate_abort #129589

saethlin · 2024-08-25T18:54:22Z

This is similar to #117332; I did the same approach as before where I build a really big project with -Zbuild-std -Zbuild-std-features=panic_immediate_abort and grep its symbols for things that look panic-related.

rustbot · 2024-08-25T18:54:29Z

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

saethlin · 2024-08-25T18:54:32Z

@bors try @rust-timer queue

bors · 2024-08-25T18:55:41Z

⌛ Trying commit b1c2c78 with merge c2e72e5...

…rt, r=<try> Tweak some attributes to improve panic_immediate_abort This is similar to rust-lang#117332; I did the same approach as before where I build a really big project with `-Zbuild-std -Zbuild-std-features=panic_immediate_abort` and grep its symbols for things that look panic-related.

bors · 2024-08-25T20:47:40Z

☀️ Try build successful - checks-actions
Build commit: c2e72e5 (c2e72e566f3bef92d5827a75fb7d8ff7056521ff)

rust-timer · 2024-08-25T22:07:31Z

Finished benchmarking commit (c2e72e5): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%, secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	0.5%	[-2.1%, 3.1%]	2

Cycles

Results (secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.0%, -2.1%]	8
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	4
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	34
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	4

Bootstrap: 752.849s -> 750.084s (-0.37%)
Artifact size: 338.80 MiB -> 338.79 MiB (-0.00%)

saethlin · 2024-08-25T22:34:31Z

library/core/src/panic/location.rs

@@ -195,6 +195,7 @@ impl<'a> Location<'a> {

 #[stable(feature = "panic_hook_display", since = "1.26.0")]
 impl fmt::Display for Location<'_> {
+    #[inline]


This showed up in my grep for symbols with panic in their name, and based on #117727 I figured it might produce some small improvement. Perf report seems to back that up. very small improvement in binary size.

Wins are wins!

tgross35 · 2024-08-25T23:01:31Z

@bors r+

bors · 2024-08-25T23:01:33Z

📌 Commit b1c2c78 has been approved by tgross35

It is now in the queue for this repository.

bors · 2024-08-26T13:36:38Z

⌛ Testing commit b1c2c78 with merge 9503a2e...

…rt, r=tgross35 Tweak some attributes to improve panic_immediate_abort This is similar to rust-lang#117332; I did the same approach as before where I build a really big project with `-Zbuild-std -Zbuild-std-features=panic_immediate_abort` and grep its symbols for things that look panic-related.

rust-log-analyzer · 2024-08-26T15:11:22Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.646
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Mon, Aug 26, 2024  3:11:04 PM
  network time: Mon, 26 Aug 2024 15:11:05 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-08-26T15:12:10Z

💔 Test failed - checks-actions

saethlin · 2024-08-26T15:46:37Z

@bors retry

…rt, r=tgross35 Tweak some attributes to improve panic_immediate_abort This is similar to rust-lang#117332; I did the same approach as before where I build a really big project with `-Zbuild-std -Zbuild-std-features=panic_immediate_abort` and grep its symbols for things that look panic-related.

bors · 2024-08-28T07:06:57Z

⌛ Testing commit b1c2c78 with merge 41ac43f...

rust-log-analyzer · 2024-08-28T08:52:27Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.542
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Wed, Aug 28, 2024  8:52:13 AM
  network time: Wed, 28 Aug 2024 08:52:13 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-08-28T08:53:03Z

💔 Test failed - checks-actions

saethlin · 2024-08-28T12:09:47Z

@bors retry

bors · 2024-08-28T13:13:13Z

⌛ Testing commit b1c2c78 with merge ac77e88...

bors · 2024-08-28T16:05:13Z

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing ac77e88 to master...

rust-timer · 2024-08-28T17:21:20Z

Finished benchmarking commit (ac77e88): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.4%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-2.0%, 1.3%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.1%, secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	4
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	37
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	4

Bootstrap: 752.822s -> 754.008s (0.16%)
Artifact size: 338.90 MiB -> 338.87 MiB (-0.01%)

Tweak some attributes to improve panic_immediate_abort

b1c2c78

rustbot assigned tgross35 Aug 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 25, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 25, 2024

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 25, 2024

saethlin marked this pull request as ready for review August 25, 2024 22:24

saethlin commented Aug 25, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2024

bors merged commit ac77e88 into rust-lang:master Aug 28, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 28, 2024

saethlin deleted the improve-panic-immediate-abort branch August 28, 2024 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak some attributes to improve panic_immediate_abort #129589

Tweak some attributes to improve panic_immediate_abort #129589

saethlin commented Aug 25, 2024

rustbot commented Aug 25, 2024

saethlin commented Aug 25, 2024

This comment has been minimized.

bors commented Aug 25, 2024

bors commented Aug 25, 2024

This comment has been minimized.

rust-timer commented Aug 25, 2024

saethlin Aug 25, 2024

tgross35 Aug 25, 2024

tgross35 commented Aug 25, 2024

bors commented Aug 25, 2024

bors commented Aug 26, 2024

rust-log-analyzer commented Aug 26, 2024

bors commented Aug 26, 2024

saethlin commented Aug 26, 2024

bors commented Aug 28, 2024

rust-log-analyzer commented Aug 28, 2024

bors commented Aug 28, 2024

saethlin commented Aug 28, 2024

bors commented Aug 28, 2024

bors commented Aug 28, 2024

rust-timer commented Aug 28, 2024

Tweak some attributes to improve panic_immediate_abort #129589

Tweak some attributes to improve panic_immediate_abort #129589

Conversation

saethlin commented Aug 25, 2024

rustbot commented Aug 25, 2024

saethlin commented Aug 25, 2024

This comment has been minimized.

bors commented Aug 25, 2024

bors commented Aug 25, 2024

This comment has been minimized.

rust-timer commented Aug 25, 2024

Overall result: no relevant changes - no action needed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tgross35 commented Aug 25, 2024

bors commented Aug 25, 2024

bors commented Aug 26, 2024

rust-log-analyzer commented Aug 26, 2024

bors commented Aug 26, 2024

saethlin commented Aug 26, 2024

bors commented Aug 28, 2024

rust-log-analyzer commented Aug 28, 2024

bors commented Aug 28, 2024

saethlin commented Aug 28, 2024

bors commented Aug 28, 2024

bors commented Aug 28, 2024

rust-timer commented Aug 28, 2024

Overall result: no relevant changes - no action needed