Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VxWorks code refactored #128817

Merged
merged 4 commits into from
Aug 9, 2024
Merged

VxWorks code refactored #128817

merged 4 commits into from
Aug 9, 2024

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Aug 8, 2024 •
edited
Loading

  1. Extern TaskNameSet as minimum supported version of os is VxWorks 7 which would have taskNameSet
  2. Vx_TASK_NAME_LEN is 31 on VxWorks7, defined variable res.
  3. Add unsafe blocks on Non::Zero usage in available_parallelism()
  4. Update vxworks docs.
    r? @tgross35
    cc @devnexen

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
devnexen
devnexen approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@biabbas
Copy link
Contributor Author

biabbas commented Aug 8, 2024

LCTM

@devnexen You mean https://en.wikipedia.org/wiki/Long-Term_Capital_Management ?

@biabbas
Copy link
Contributor Author

biabbas commented Aug 8, 2024

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2024
@devnexen
Copy link
Contributor

devnexen commented Aug 8, 2024

Looks Correct To Me :)

tgross35
tgross35 reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup, thanks. One nit, we should try to make use of SAFETY comments where possible

@biabbas @tgross35
VxWorks: Add safety comment for vxCpuEnabledGet
b20d9f0 
Co-authored-by: Trevor Gross <t.gross35@gmail.com>
@tgross35
Copy link
Contributor

tgross35 commented Aug 9, 2024

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 9, 2024

📌 Commit b20d9f0 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
@bors
Auto merge of rust-lang#128883 - matthiaskrgr:rollup-mkzi7my, r=matth…
19ebdce 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128815 (Add `Steal::is_stolen()`)
 - rust-lang#128817 (VxWorks code refactored )
 - rust-lang#128822 (add `builder-config` into tarball sources)
 - rust-lang#128838 (rustdoc: do not run doctests with invalid langstrings)
 - rust-lang#128852 (use stable sort to sort multipart diagnostics)
 - rust-lang#128859 (Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux)
 - rust-lang#128864 (Use `SourceMap::end_point` instead of `- BytePos(1)` in arg removal suggestion)
 - rust-lang#128865 (Ensure let stmt compound assignment removal suggestion respect codepoint boundaries)
 - rust-lang#128874 (Disable verbose bootstrap command failure logging by default)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5372936 into rust-lang:master Aug 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
@rust-timer
Unrolled build for rust-lang#128817
81026bc 
Rollup merge of rust-lang#128817 - biabbas:vxworks_update, r=tgross35

VxWorks code refactored

1. Extern TaskNameSet as minimum supported version of os is VxWorks 7 which would have taskNameSet
2. Vx_TASK_NAME_LEN is 31 on VxWorks7, defined variable res.
3. Add unsafe blocks on Non::Zero usage in available_parallelism()
4. Update vxworks docs.
r? `@tgross35`
cc `@devnexen`
@biabbas biabbas deleted the vxworks_update branch August 12, 2024 04:00
@ChrisDenton ChrisDenton mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 left review comments

@devnexen devnexen devnexen approved these changes

Assignees

@tgross35 tgross35

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@biabbas @rustbot @rust-log-analyzer @devnexen @tgross35 @bors