-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: move allocators to sys
#128134
std: move allocators to sys
#128134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was identical to the UNIX version.
This comment has been minimized.
This comment has been minimized.
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #128142) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #128481) made this pull request unmergeable. Please resolve the merge conflicts. |
LGTM! @bors r+ rollup=iffy |
@bors rollup=iffy |
std: move allocators to `sys` Part of rust-lang#117276.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
I forgot to check SGX and forgot some imports... @bors r=cupiver |
std: move allocators to `sys` Part of rust-lang#117276.
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
That looks spurious. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (600edc9): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.058s -> 749.925s (-0.15%) |
Part of #117276.