Fix compile error in solid's remove_dir_all #129907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-solid
|
seems reasonable @bors r+ rollup |
bors
added
S-waiting-on-bors
WaffleLapkin
approved these changes
Sep 2, 2024
|
@bors r+ rollup |
|
💡 This pull request was already approved, no need to approve it again.
|
|
solid fix, 10/10! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 2, 2024
…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#129748 (Box validity: update for new zero-sized rules) - rust-lang#129829 (Make decoding non-optional `LazyArray` panic if not set) - rust-lang#129856 (compiler_fence documentation: emphasize synchronization, not reordering) - rust-lang#129868 (Remove kobzol vacation status) - rust-lang#129875 (chore: Fix typos in 'compiler' (batch 1)) - rust-lang#129877 (chore: Fix typos in 'compiler' (batch 2)) - rust-lang#129878 (chore: Fix typos in 'compiler' (batch 3)) - rust-lang#129890 (Remove stray word in a comment) - rust-lang#129892 (Clarify language around ptrs in slice::raw) - rust-lang#129905 (mailmap: add new email for davidtwco) - rust-lang#129906 (mailmapper?) - rust-lang#129907 (Fix compile error in solid's remove_dir_all) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2024
Rollup merge of rust-lang#129907 - saethlin:solid-io-error, r=WaffleLapkin Fix compile error in solid's remove_dir_all Before this PR, `x check library/std --target=aarch64-kmc-solid_asp3` will fail with: ``` error[E0382]: use of partially moved value: `result` --> std/src/sys/pal/solid/fs.rs:544:20 | 541 | if let Err(err) = result | --- value partially moved here ... 544 | return result; | ^^^^^^ value used here after partial move | = note: partial move occurs because value has type `io::error::Error`, which does not implement the `Copy` trait help: borrow this binding in the pattern to avoid moving the value | 541 | if let Err(ref err) = result | +++ ``` cc `@kawadakk` I think this will clear up https://solid-rs.github.io/toolstate/ :)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
x check library/std --target=aarch64-kmc-solid_asp3will fail with:cc @kawadakk I think this will clear up https://solid-rs.github.io/toolstate/ :)