Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement BufReader::peek #128406

Merged
merged 1 commit into from
Aug 7, 2024
Merged

implement BufReader::peek #128406

merged 1 commit into from
Aug 7, 2024

Conversation

lolbinarycat
Copy link
Contributor

Part of #128405

@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 30, 2024
@lolbinarycat lolbinarycat mentioned this pull request Jul 30, 2024
Open
4 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added the F-bufreader_peek `#![feature(bufreader_peek)]` label Jul 31, 2024
@biabbas
Copy link
Contributor

biabbas commented Aug 2, 2024 •
edited
Loading

Lets try
@bors r+
Np

@bors
Copy link
Collaborator

bors commented Aug 2, 2024

@biabbas: 🔑 Insufficient privileges: Not in reviewers

@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

@lolbinarycat
Copy link
Contributor Author

r=@Mark-Simulacrum

@the8472
Copy link
Member

the8472 commented Aug 5, 2024

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Aug 5, 2024

📌 Commit 4af77df has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#128406 - lolbinarycat:bufreader_peek, r=Mar…
7a9fea2 
…k-Simulacrum

implement BufReader::peek

Part of rust-lang#128405
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 6, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
@bors
Auto merge of rust-lang#128719 - matthiaskrgr:rollup-rbjs7bc, r=matth…
a357411 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#122792 (Stabilize `min_exhaustive_patterns`)
 - rust-lang#124944 (On trait bound mismatch, detect multiple crate versions in dep tree)
 - rust-lang#128273 (Improve `Ord` violation help)
 - rust-lang#128406 (implement BufReader::peek)
 - rust-lang#128539 (Forbid unused unsafe in vxworks-specific std modules)
 - rust-lang#128692 (Add a triagebot mention for `library/Cargo.lock`)
 - rust-lang#128710 (Don't ICE when getting an input file name's stem fails)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#128406 - lolbinarycat:bufreader_peek, r=Mar…
96cc747 
…k-Simulacrum

implement BufReader::peek

Part of rust-lang#128405
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 6, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
@bors
Auto merge of rust-lang#128739 - matthiaskrgr:rollup-d7ecih7, r=matth…
e86636c 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#125048 (PinCoerceUnsized trait into core)
 - rust-lang#128273 (Improve `Ord` violation help)
 - rust-lang#128406 (implement BufReader::peek)
 - rust-lang#128539 (Forbid unused unsafe in vxworks-specific std modules)
 - rust-lang#128687 (interpret: refactor function call handling to be better-abstracted)
 - rust-lang#128692 (Add a triagebot mention for `library/Cargo.lock`)
 - rust-lang#128710 (Don't ICE when getting an input file name's stem fails)
 - rust-lang#128718 (Consider `cfg_attr` checked by `CheckAttrVisitor`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
@bors
Auto merge of rust-lang#128739 - matthiaskrgr:rollup-d7ecih7, r=matth…
a1486cf 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#125048 (PinCoerceUnsized trait into core)
 - rust-lang#128273 (Improve `Ord` violation help)
 - rust-lang#128406 (implement BufReader::peek)
 - rust-lang#128539 (Forbid unused unsafe in vxworks-specific std modules)
 - rust-lang#128687 (interpret: refactor function call handling to be better-abstracted)
 - rust-lang#128692 (Add a triagebot mention for `library/Cargo.lock`)
 - rust-lang#128710 (Don't ICE when getting an input file name's stem fails)
 - rust-lang#128718 (Consider `cfg_attr` checked by `CheckAttrVisitor`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 6, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
@bors
Auto merge of rust-lang#128761 - matthiaskrgr:rollup-5p1mlqq, r=matth…
6696447 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#124944 (On trait bound mismatch, detect multiple crate versions in dep tree)
 - rust-lang#125048 (PinCoerceUnsized trait into core)
 - rust-lang#128406 (implement BufReader::peek)
 - rust-lang#128539 (Forbid unused unsafe in vxworks-specific std modules)
 - rust-lang#128687 (interpret: refactor function call handling to be better-abstracted)
 - rust-lang#128692 (Add a triagebot mention for `library/Cargo.lock`)
 - rust-lang#128710 (Don't ICE when getting an input file name's stem fails)
 - rust-lang#128718 (Consider `cfg_attr` checked by `CheckAttrVisitor`)
 - rust-lang#128751 (std::thread: set_name implementation proposal for vxWorks.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e1360b into rust-lang:master Aug 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
@rust-timer
Unrolled build for rust-lang#128406
c5fb1f4 
Rollup merge of rust-lang#128406 - lolbinarycat:bufreader_peek, r=Mark-Simulacrum

implement BufReader::peek

Part of rust-lang#128405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

@the8472 the8472 the8472 left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
F-bufreader_peek `#![feature(bufreader_peek)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
9 participants
@lolbinarycat @rustbot @rust-log-analyzer @biabbas @bors @Mark-Simulacrum @the8472 @fbstj @jieyouxu