process.rs: remove "Basic usage" text where not useful #129916
Conversation
Is not useful because just a single example is given.
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
rustbot
added
S-waiting-on-review
|
If an example is marked as "Basic usage", I would expect for there to also be "Advanced usage" example (or similar), but in these cases, only a single example is given. Also, it would be too verbose to try to explain these examples, and they are already explained in the API and in the docs. I see the examples as complementary, and should offer clarity on their own. If not, we could add additional text to explain. |
|
oh, I see they removed their comment... they were concerned that the pr removes clarity, and that I should rather state what the examples do |
|
"basic usage" does seem redundant given the context @bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#129152 (custom/external clippy support for bootstrapping) - rust-lang#129311 (don't copy `.rustc-dev-contents` from CI rustc) - rust-lang#129800 (Move the Windows remove_dir_all impl into a module and make it more race resistant) - rust-lang#129860 (update `object` dependency to remove duplicate `wasmparser`) - rust-lang#129885 (chore: remove repetitive words) - rust-lang#129913 (Add missing read_buf stub for x86_64-unknown-l4re-uclibc) - rust-lang#129916 (process.rs: remove "Basic usage" text where not useful) - rust-lang#129917 (Fix parsing of beta version in dry-run mode) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#129916 - tshepang:basic-usage, r=ChrisDenton process.rs: remove "Basic usage" text where not useful Is not useful because just a single example is given.
Is not useful because just a single example is given.