Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #129516

Closed
wants to merge 20 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 20 commits August 17, 2024 14:49
`cc` 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we
don't drop support yet.

Fixes: rust-lang#128722 (comment)
…rithmetic, r=nnethercote

stabilize const_fn_floating_point_arithmetic

Part of rust-lang#128288
Fixes rust-lang#57241

The existing test `tests/ui/consts/const_let_eq_float.rs`  ([link](https://github.com/RalfJung/rust/blob/const_fn_floating_point_arithmetic/tests/ui/consts/const_let_eq_float.rs)) covers the basics, and also Miri has extensive tests covering the interpreter's float machinery. Also, that machinery can already be used on stable inside `const`/`static` initializers, just not inside `const fn`.

This was explicitly called out in rust-lang/rfcs#3514 so in a sense t-lang just recently already FCP'd this, but let's hear from them whether they want another FCP for the stabilization here or whether that was covered by the FCP for the RFC.
Cc `@rust-lang/lang`

### Open items

- [x] Update the Reference: rust-lang/reference#1566
…pointer, r=compiler-errors

make writes_through_immutable_pointer a hard error

This turns the lint added in rust-lang#118324 into a hard error. This has been reported in cargo's future-compat reports since Rust 1.76 (released in February). Given that const_mut_refs is still unstable, it should be impossible to even hit this error on stable: we did accidentally stabilize some functions that can cause this error, but that got reverted in rust-lang#117905. Still, let's do a crater run just to be sure.

Given that this should only affect unstable code, I don't think it needs an FCP, but let's Cc `@rust-lang/lang` anyway -- any objection to making this unambiguous UB into a hard error during const-eval? This can be viewed as part of rust-lang#129195 which is already nominated for discussion.
…h, r=cjgillot

Retroactively feature gate `ConstArgKind::Path`

This puts the lowering introduced by rust-lang#125915 under a feature gate until we fix the regressions introduced by it. Alternative to whole sale reverting the PR since it didn't seem like a very clean revert and I think this is generally a step in the right direction and don't want to get stuck landing and reverting the PR over and over :)

cc rust-lang#129137 `@camelid,` tests taken from there. beta is branching soon so I think it makes sense to not try and rush that fix through since it wont have much time to bake and if it has issues we can't simply revert it on beta.

Fixes rust-lang#128016
Pin `cc` to 1.0.105

`cc` 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we don't drop support yet.

Fixes: rust-lang#128722 (comment)
…acrum

Implement `ptr::fn_addr_eq`

This PR implements rust-lang/libs-team#323: `ptr::fn_addr_eq`.

r? libs
…r-errors

remove invalid `TyCompat` relation for effects

if the current impl uses `Maybe` (`impl const`), the parent impl must use `Maybe` (`impl const`) as well.

I'd like to rename `TyCompat` to `Sub` which is probably clearer. But it would conflict with my other PR.

r? `@rust-lang/project-const-traits`
…ratrieb

panicking: improve hint for Miri's RUST_BACKTRACE behavior

Should help with rust-lang/miri#3838
interpret: ImmTy: tighten sanity checks in offset logic

Also make some debug assertions into assertions. (Will need to be perf'd.)
…-Simulacrum

Add a hack to workaround MSVC CI issues

I'm still attempting to figure out the issue but the failure rate atm seems really high so I'd like to propose an interim hack.

This adds a single delay of 5 minutes, which is absurdly long in CPU time but practically nothing compared to overall CI time.
…times, r=cjgillot

Fix `elided_named_lifetimes` in code

rust-lang#129207 (comment)

r? cjgillot
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 24, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=10

@bors
Copy link
Contributor

bors commented Aug 24, 2024

📌 Commit 000d070 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2024
@bors
Copy link
Contributor

bors commented Aug 24, 2024

⌛ Testing commit 000d070 with merge dd51090...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
 - rust-lang#129199 (make writes_through_immutable_pointer a hard error)
 - rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
 - rust-lang#129290 (Pin `cc` to 1.0.105)
 - rust-lang#129323 (Implement `ptr::fn_addr_eq`)
 - rust-lang#129500 (remove invalid `TyCompat` relation for effects)
 - rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
 - rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
 - rust-lang#129509 (Add a hack to workaround MSVC CI issues)
 - rust-lang#129510 (Fix `elided_named_lifetimes` in code)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[endgroup]
[TIMING] core::build_steps::test::CargoMiri { target: x86_64-pc-windows-msvc } -- 44.415
Build completed successfully in 0:13:55
+ case $HOST_TARGET in
+ ps -W
      PID    PPID    PGID     WINPID   TTY         UID    STIME COMMAND
    65540       0       0          4  ?              0 18:14:15 System
    65640       0       0        104  ?              0 18:14:14 *** unknown ***
    65700       0       0        164  ?              0 18:14:14 Registry
    66144       0       0        608  ?              0 18:14:15 C:\Windows\System32\smss.exe
    66332       0       0        796  ?              0 18:14:26 C:\Windows\System32\csrss.exe
    66412       0       0        876  ?              0 18:14:26 C:\Windows\System32\wininit.exe
    66556       0       0       1020  ?              0 18:14:26 C:\Windows\System32\services.exe
    66100       0       0        564  ?              0 18:14:26 C:\Windows\System32\lsass.exe
    66576       0       0       1040  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66612       0       0       1076  ?              0 18:14:27 C:\Windows\System32\fontdrvhost.exe
    66680       0       0       1144  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66728       0       0       1192  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66876       0       0       1340  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66956       0       0       1420  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67068       0       0       1532  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67232       0       0       1696  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67240       0       0       1704  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67268       0       0       1732  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67344       0       0       1808  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67384       0       0       1848  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67392       0       0       1856  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67400       0       0       1864  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67408       0       0       1872  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67480       0       0       1944  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67132       0       0       1596  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    66232       0       0        696  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67604       0       0       2068  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67640       0       0       2104  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67716       0       0       2180  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67724       0       0       2188  ?              0 18:14:31 C:\Windows\System32\vmms.exe
    67772       0       0       2236  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67892       0       0       2356  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67900       0       0       2364  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67908       0       0       2372  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68028       0       0       2492  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68052       0       0       2516  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68072       0       0       2536  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68080       0       0       2544  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68140       0       0       2604  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68220       0       0       2684  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68256       0       0       2720  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68292       0       0       2756  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68388       0       0       2852  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68492       0       0       2956  ?              0 18:14:31 C:\Windows\System32\spoolsv.exe
    68600       0       0       3064  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68048       0       0       2512  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67864       0       0       2328  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68136       0       0       2600  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68284       0       0       2748  ?              0 18:14:31 C:\ProgramData\Microsoft\Windows Defender\Platform\4.18.24070.5-0\MsMpEng.exe
    68132       0       0       2596  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68448       0       0       2912  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68620       0       0       3084  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68668       0       0       3132  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68688       0       0       3152  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68696       0       0       3160  ?              0 18:14:31 C:\Windows\System32\mqsvc.exe
    68704       0       0       3168  ?              0 18:14:31 C:\Windows\Microsoft.NET\Framework64\v4.0.30319\SMSvcHost.exe
    68740       0       0       3204  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68752       0       0       3216  ?              0 18:14:31 C:\Program Files\Microsoft SQL Server\90\Shared\sqlwriter.exe
    68972       0       0       3436  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    69584       0       0       4048  ?              0 18:14:31 C:\Windows\Microsoft.NET\Framework64\v4.0.30319\SMSvcHost.exe
    69944       0       0       4408  ?              0 18:14:32 C:\Windows\System32\dockerd.exe
    70104       0       0       4568  ?              0 18:14:32 C:\Windows\System32\svchost.exe
    70148       0       0       4612  ?              0 18:14:32 C:\Windows\System32\svchost.exe
    69820       0       0       4284  ?              0 18:14:41 C:\Windows\System32\svchost.exe
    69836       0       0       4300  ?              0 18:14:41 C:\Windows\System32\vmcompute.exe
    69684       0       0       4148  ?              0 18:14:41 C:\Windows\System32\svchost.exe
    70892       0       0       5356  ?              0 18:14:42 C:\Windows\System32\svchost.exe
    71028       0       0       5492  ?              0 18:14:42 C:\Windows\System32\svchost.exe
    71080       0       0       5544  ?              0 18:14:42 C:\Windows\System32\svchost.exe
    71388       0       0       5852  ?              0 18:14:43 C:\WindowsAzure\GuestAgent_2.7.41491.1131_2024-08-11_210822\WaAppAgent.exe
    70616       0       0       5080  ?              0 18:14:43 C:\WindowsAzure\GuestAgent_2.7.41491.1131_2024-08-11_210822\WindowsAzureGuestAgent.exe
    70420       0       0       4884  ?              0 18:14:45 C:\Windows\System32\taskhostw.exe
    71272       0       0       5736  ?              0 18:14:45 C:\Windows\System32\svchost.exe
    71152       0       0       5616  ?              0 18:14:46 C:\Windows\System32\svchost.exe
    70684       0       0       5148  ?              0 18:14:55 C:\WindowsAzure\SecAgent\WaSecAgentProv.exe
    69976       0       0       4440  ?              0 18:14:55 C:\Windows\System32\conhost.exe
    72592       0       0       7056  ?              0 18:16:11 C:\Windows\System32\vds.exe
    70384       0       0       4848  ?              0 18:16:14 C:\Windows\System32\csrss.exe
    66924       0       0       1388  ?              0 18:16:14 C:\Windows\System32\winlogon.exe
    67544       0       0       2008  ?              0 18:16:14 C:\Windows\System32\fontdrvhost.exe
    67660       0       0       2124  ?              0 18:16:14 C:\Windows\System32\dwm.exe
    70112       0       0       4576  ?              0 18:16:18 C:\Windows\System32\taskhostw.exe
    72688       0       0       7152  ?              0 18:16:18 C:\Windows\System32\sihost.exe
    68064       0       0       2528  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    67476       0       0       1940  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    68112       0       0       2576  ?              0 18:16:18 C:\Windows\System32\ctfmon.exe
    69792       0       0       4256  ?              0 18:16:18 C:\Windows\System32\taskhostw.exe
    69844       0       0       4308  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    71724       0       0       6188  ?              0 18:16:18 C:\Windows\explorer.exe
    72564       0       0       7028  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    66428       0       0        892  ?              0 18:16:19 C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
    70828       0       0       5292  ?              0 18:16:19 C:\Windows\System32\conhost.exe
    72068       0       0       6532  ?              0 18:16:19 C:\actions-runner\provisioning\provjobd.exe
    72908       0       0       7372  ?              0 18:16:20 C:\Windows\System32\svchost.exe
    73016       0       0       7480  ?              0 18:16:20 C:\Windows\System32\cmd.exe
    73024       0       0       7488  ?              0 18:16:20 C:\Windows\System32\conhost.exe
    73088       0       0       7552  ?              0 18:16:21 C:\Windows\SystemApps\MicrosoftWindows.Client.CBS_cw5n1h2txyewy\TextInputHost.exe
    73304       0       0       7768  ?              0 18:16:21 C:\actions-runner\bin\Runner.Listener.exe
    73508       0       0       7972  ?              0 18:16:22 C:\Windows\System32\svchost.exe
    73552       0       0       8016  ?              0 18:16:22 C:\Windows\SystemApps\Microsoft.Windows.StartMenuExperienceHost_cw5n1h2txyewy\StartMenuExperienceHost.exe
    73632       0       0       8096  ?              0 18:16:22 C:\Windows\System32\RuntimeBroker.exe
    73724       0       0       8188  ?              0 18:16:22 C:\Windows\SystemApps\Microsoft.Windows.Search_cw5n1h2txyewy\SearchApp.exe
    72616       0       0       7080  ?              0 18:16:22 C:\Windows\System32\RuntimeBroker.exe
    72936       0       0       7400  ?              0 18:16:23 C:\actions-runner\bin\Runner.Worker.exe
    73028       0       0       7492  ?              0 18:16:23 C:\Windows\System32\conhost.exe
    66652       0       0       1116  ?              0 18:16:27 C:\Windows\System32\RuntimeBroker.exe
    72336       0       0       6800  ?              0 18:16:32 C:\Windows\System32\svchost.exe
    72468       0       0       6932  ?              0 18:16:32 C:\Windows\System32\svchost.exe
    72188       0       0       6652  ?              0 18:16:33 C:\Windows\System32\msdtc.exe
    71256       0       0       5720  ?              0 18:16:33 C:\Windows\System32\svchost.exe
    67264       0       0       1728  ?              0 18:16:33 C:\Windows\AzureArcSetup\Systray\AzureArcSysTray.exe
    71600       0       0       6064  ?              0 18:16:33 C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager\ServiceFabricLocalClusterManager.exe
    67148       0       0       1612  ?              0 18:16:34 C:\Windows\SystemApps\ShellExperienceHost_cw5n1h2txyewy\ShellExperienceHost.exe
    73816       0       0       8280  ?              0 18:16:34 C:\Windows\System32\RuntimeBroker.exe
    73948       0       0       8412  ?              0 18:16:34 C:\Windows\System32\svchost.exe
    74036       0       0       8500  ?              0 18:16:34 C:\Windows\System32\svchost.exe
    70412       0       0       4876  ?              0 18:17:19 C:\a\_temp\msys64\usr\bin\bash.exe
     1324       1    1311       8936  ?         197108 18:17:19 /c/hostedtoolcache/windows/Python/3.9.13/x64/python3
    74592       0       0       9056  ?              0 18:19:12 C:\Windows\System32\cmd.exe
     1584       1    1584       5368  ?         197108 18:19:11 /usr/bin/bash
     1595    1584    1584       7920  ?         197108 18:19:11 /usr/bin/bash
     1599    1595    1584       4824  ?         197108 18:19:12 /usr/bin/bash
    74000       0       0       8464  ?              0 18:19:13 C:\a\rust\rust\sccache\sccache.exe
    67120       0       0       1584  ?              0 18:19:29 C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\bin\Hostx64\x64\vctip.exe
     1623    1599    1584       8088  ?         197108 18:20:19 /usr/bin/sh
     1659    1623    1584       6952  ?         197108 19:48:35 /usr/bin/ps
+ echo 'HACK: sleeping for 5 minutes'
HACK: sleeping for 5 minutes
+ ps -W
+ ps -W
      PID    PPID    PGID     WINPID   TTY         UID    STIME COMMAND
    65540       0       0          4  ?              0 18:14:15 System
    65640       0       0        104  ?              0 18:14:14 *** unknown ***
    65700       0       0        164  ?              0 18:14:14 Registry
    66144       0       0        608  ?              0 18:14:15 C:\Windows\System32\smss.exe
    66332       0       0        796  ?              0 18:14:26 C:\Windows\System32\csrss.exe
    66412       0       0        876  ?              0 18:14:26 C:\Windows\System32\wininit.exe
    66556       0       0       1020  ?              0 18:14:26 C:\Windows\System32\services.exe
    66100       0       0        564  ?              0 18:14:26 C:\Windows\System32\lsass.exe
    66576       0       0       1040  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66612       0       0       1076  ?              0 18:14:27 C:\Windows\System32\fontdrvhost.exe
    66680       0       0       1144  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66728       0       0       1192  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66876       0       0       1340  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    66956       0       0       1420  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67068       0       0       1532  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67232       0       0       1696  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67240       0       0       1704  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67268       0       0       1732  ?              0 18:14:27 C:\Windows\System32\svchost.exe
    67344       0       0       1808  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67384       0       0       1848  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67392       0       0       1856  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67400       0       0       1864  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67408       0       0       1872  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67480       0       0       1944  ?              0 18:14:28 C:\Windows\System32\svchost.exe
    67132       0       0       1596  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    66232       0       0        696  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67604       0       0       2068  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67640       0       0       2104  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67716       0       0       2180  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67724       0       0       2188  ?              0 18:14:31 C:\Windows\System32\vmms.exe
    67772       0       0       2236  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67892       0       0       2356  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67900       0       0       2364  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67908       0       0       2372  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68028       0       0       2492  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68052       0       0       2516  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68072       0       0       2536  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68080       0       0       2544  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68140       0       0       2604  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68220       0       0       2684  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68256       0       0       2720  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68292       0       0       2756  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68388       0       0       2852  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68492       0       0       2956  ?              0 18:14:31 C:\Windows\System32\spoolsv.exe
    68600       0       0       3064  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68048       0       0       2512  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    67864       0       0       2328  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68136       0       0       2600  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68284       0       0       2748  ?              0 18:14:31 C:\ProgramData\Microsoft\Windows Defender\Platform\4.18.24070.5-0\MsMpEng.exe
    68132       0       0       2596  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68448       0       0       2912  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68620       0       0       3084  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68668       0       0       3132  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68688       0       0       3152  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68696       0       0       3160  ?              0 18:14:31 C:\Windows\System32\mqsvc.exe
    68704       0       0       3168  ?              0 18:14:31 C:\Windows\Microsoft.NET\Framework64\v4.0.30319\SMSvcHost.exe
    68740       0       0       3204  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    68752       0       0       3216  ?              0 18:14:31 C:\Program Files\Microsoft SQL Server\90\Shared\sqlwriter.exe
    68972       0       0       3436  ?              0 18:14:31 C:\Windows\System32\svchost.exe
    69584       0       0       4048  ?              0 18:14:31 C:\Windows\Microsoft.NET\Framework64\v4.0.30319\SMSvcHost.exe
    69944       0       0       4408  ?              0 18:14:32 C:\Windows\System32\dockerd.exe
    70104       0       0       4568  ?              0 18:14:32 C:\Windows\System32\svchost.exe
    70148       0       0       4612  ?              0 18:14:32 C:\Windows\System32\svchost.exe
    69820       0       0       4284  ?              0 18:14:41 C:\Windows\System32\svchost.exe
    69836       0       0       4300  ?              0 18:14:41 C:\Windows\System32\vmcompute.exe
    69684       0       0       4148  ?              0 18:14:41 C:\Windows\System32\svchost.exe
    70892       0       0       5356  ?              0 18:14:42 C:\Windows\System32\svchost.exe
    71028       0       0       5492  ?              0 18:14:42 C:\Windows\System32\svchost.exe
    71080       0       0       5544  ?              0 18:14:42 C:\Windows\System32\svchost.exe
    71388       0       0       5852  ?              0 18:14:43 C:\WindowsAzure\GuestAgent_2.7.41491.1131_2024-08-11_210822\WaAppAgent.exe
    70616       0       0       5080  ?              0 18:14:43 C:\WindowsAzure\GuestAgent_2.7.41491.1131_2024-08-11_210822\WindowsAzureGuestAgent.exe
    70420       0       0       4884  ?              0 18:14:45 C:\Windows\System32\taskhostw.exe
    71272       0       0       5736  ?              0 18:14:45 C:\Windows\System32\svchost.exe
    71152       0       0       5616  ?              0 18:14:46 C:\Windows\System32\svchost.exe
    70684       0       0       5148  ?              0 18:14:55 C:\WindowsAzure\SecAgent\WaSecAgentProv.exe
    69976       0       0       4440  ?              0 18:14:55 C:\Windows\System32\conhost.exe
    72592       0       0       7056  ?              0 18:16:11 C:\Windows\System32\vds.exe
    70384       0       0       4848  ?              0 18:16:14 C:\Windows\System32\csrss.exe
    66924       0       0       1388  ?              0 18:16:14 C:\Windows\System32\winlogon.exe
    67544       0       0       2008  ?              0 18:16:14 C:\Windows\System32\fontdrvhost.exe
    67660       0       0       2124  ?              0 18:16:14 C:\Windows\System32\dwm.exe
    70112       0       0       4576  ?              0 18:16:18 C:\Windows\System32\taskhostw.exe
    72688       0       0       7152  ?              0 18:16:18 C:\Windows\System32\sihost.exe
    68064       0       0       2528  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    67476       0       0       1940  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    68112       0       0       2576  ?              0 18:16:18 C:\Windows\System32\ctfmon.exe
    69792       0       0       4256  ?              0 18:16:18 C:\Windows\System32\taskhostw.exe
    69844       0       0       4308  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    71724       0       0       6188  ?              0 18:16:18 C:\Windows\explorer.exe
    72564       0       0       7028  ?              0 18:16:18 C:\Windows\System32\svchost.exe
    66428       0       0        892  ?              0 18:16:19 C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
    70828       0       0       5292  ?              0 18:16:19 C:\Windows\System32\conhost.exe
    72068       0       0       6532  ?              0 18:16:19 C:\actions-runner\provisioning\provjobd.exe
    72908       0       0       7372  ?              0 18:16:20 C:\Windows\System32\svchost.exe
    73016       0       0       7480  ?              0 18:16:20 C:\Windows\System32\cmd.exe
    73024       0       0       7488  ?              0 18:16:20 C:\Windows\System32\conhost.exe
    73088       0       0       7552  ?              0 18:16:21 C:\Windows\SystemApps\MicrosoftWindows.Client.CBS_cw5n1h2txyewy\TextInputHost.exe
    73304       0       0       7768  ?              0 18:16:21 C:\actions-runner\bin\Runner.Listener.exe
    73508       0       0       7972  ?              0 18:16:22 C:\Windows\System32\svchost.exe
    73552       0       0       8016  ?              0 18:16:22 C:\Windows\SystemApps\Microsoft.Windows.StartMenuExperienceHost_cw5n1h2txyewy\StartMenuExperienceHost.exe
    73632       0       0       8096  ?              0 18:16:22 C:\Windows\System32\RuntimeBroker.exe
    73724       0       0       8188  ?              0 18:16:22 C:\Windows\SystemApps\Microsoft.Windows.Search_cw5n1h2txyewy\SearchApp.exe
    72616       0       0       7080  ?              0 18:16:22 C:\Windows\System32\RuntimeBroker.exe
    72936       0       0       7400  ?              0 18:16:23 C:\actions-runner\bin\Runner.Worker.exe
    73028       0       0       7492  ?              0 18:16:23 C:\Windows\System32\conhost.exe
    66652       0       0       1116  ?              0 18:16:27 C:\Windows\System32\RuntimeBroker.exe
    72336       0       0       6800  ?              0 18:16:32 C:\Windows\System32\svchost.exe
    72468       0       0       6932  ?              0 18:16:32 C:\Windows\System32\svchost.exe
    72188       0       0       6652  ?              0 18:16:33 C:\Windows\System32\msdtc.exe
    71256       0       0       5720  ?              0 18:16:33 C:\Windows\System32\svchost.exe
    67264       0       0       1728  ?              0 18:16:33 C:\Windows\AzureArcSetup\Systray\AzureArcSysTray.exe
    71600       0       0       6064  ?              0 18:16:33 C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager\ServiceFabricLocalClusterManager.exe
    67148       0       0       1612  ?              0 18:16:34 C:\Windows\SystemApps\ShellExperienceHost_cw5n1h2txyewy\ShellExperienceHost.exe
    73816       0       0       8280  ?              0 18:16:34 C:\Windows\System32\RuntimeBroker.exe
    73948       0       0       8412  ?              0 18:16:34 C:\Windows\System32\svchost.exe
    74036       0       0       8500  ?              0 18:16:34 C:\Windows\System32\svchost.exe
    70412       0       0       4876  ?              0 18:17:19 C:\a\_temp\msys64\usr\bin\bash.exe
     1324       1    1311       8936  ?         197108 18:17:19 /c/hostedtoolcache/windows/Python/3.9.13/x64/python3
    74592       0       0       9056  ?              0 18:19:12 C:\Windows\System32\cmd.exe
     1584       1    1584       5368  ?         197108 18:19:11 /usr/bin/bash
     1595    1584    1584       7920  ?         197108 18:19:11 /usr/bin/bash
     1599    1595    1584       4824  ?         197108 18:19:12 /usr/bin/bash
    74000       0       0       8464  ?              0 18:19:13 C:\a\rust\rust\sccache\sccache.exe
    67120       0       0       1584  ?              0 18:19:29 C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\bin\Hostx64\x64\vctip.exe
     1623    1599    1584       8088  ?         197108 18:20:19 /usr/bin/sh
     1661    1623    1584       6904  ?         197108 19:53:35 /usr/bin/ps
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.10s
##[endgroup]
cargo:warning=Compiler family detection failed due to error: ToolNotFound: Failed to find tool. Is `cc` installed? (see https://github.com/rust-lang/cc-rs#compile-time-requirements for help)
---
[RUSTC-TIMING] miri test:false 4.389
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Sat, Aug 24, 2024  7:54:33 PM
  network time: Sat, 24 Aug 2024 19:54:33 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Aug 24, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2024
@jieyouxu
Copy link
Member

😭

@ChrisDenton
Copy link
Member

Hm, must have been a fluke that it worked in my tests. At least it ruled out another option I guess.

@jieyouxu
Copy link
Member

@bors r- (the hack should probably not be in a rollup)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2024
@matthiaskrgr matthiaskrgr deleted the rollup-u13wr8q branch September 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.