Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for S_OBJNAME #130155

Closed
wants to merge 1 commit into from
Closed

Add test for S_OBJNAME #130155

wants to merge 1 commit into from

Conversation

nebulark
Copy link
Contributor

@nebulark nebulark commented Sep 9, 2024

Add the missing test for #96475
This checks if in the pdb exist an S_OBJNAME entry with the name of the .o file.

@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@nebulark
Copy link
Contributor Author

nebulark commented Sep 9, 2024

@rustbot label: +O-windows

@rustbot rustbot added the O-windows Operating system: Windows label Sep 9, 2024
@nebulark nebulark mentioned this pull request Sep 9, 2024
Closed
jieyouxu
jieyouxu approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one question

tests/run-make/pdb-sobjname/rmake.rs
let pdbutil_result =
llvm::LlvmPdbutil::new().arg("dump").arg("-symbols").input("my_great_crate_name.pdb").run();

llvm::llvm_filecheck().patterns("filecheck.txt").stdin_buf(pdbutil_result.stdout_utf8()).run();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: does this need to use filecheck? Or can this just use something like assert_stdout_contains_regex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case assert_stdout_contains_regex should work as it is just one line.

@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2024
@nebulark nebulark mentioned this pull request Sep 10, 2024
Merged
@nebulark
Copy link
Contributor Author

Move the changes into #130156 to make merging easier.

@nebulark nebulark closed this Sep 10, 2024
@nebulark nebulark deleted the test_sobjname branch September 10, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs O-windows Operating system: Windows S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nebulark @rustbot @jieyouxu