coverage: Simplify creation of sum counters #130263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zalathar
added
the
A-code-coverage
Swatinem
reviewed
Sep 12, 2024
|
I guess I should have read the description more carefully 🙈 don’t mind me then, as it looks like you will be needing a |
|
Yeah, creating the intermediate vector is deliberate, so that the two steps are clearly separate (and can be pulled further apart without additional hassle). |
|
And while I could make the helper take an iterator instead of a slice, I prefer the direct simplicity of the slice. It would be easy enough to change that back to taking an iterator if necessary, but I don't foresee that happening in the near future. |
|
Hmm, was rustbot asleep? r? compiler |
rustbot
added
the
T-compiler
compiler-errors
approved these changes
Sep 12, 2024
|
@bors r+ rollup |
bors
added
the
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 12, 2024
coverage: Simplify creation of sum counters A small and self-contained improvement, extracted from some larger changes that I'm still working on. Ultimately I want to avoid creating these sum counter-expressions in some cases (in favour of just adding physical counters directly to the nodes we care about), so a good incremental move towards that is splitting the “gather edge counters” step out from the ”build a sum of those counters” step. Creating an extra intermediate vector should have negligible cost (and coverage isn't exercised by the benchmark suite anyway). The removed logging is redundant with the `#[instrument(..)]` logging we already have on the underlying method calls.
This was referenced Sep 12, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130101 (some const cleanup: remove unnecessary attributes, add const-hack indications) - rust-lang#130208 (Introduce `'ra` lifetime name.) - rust-lang#130263 (coverage: Simplify creation of sum counters) - rust-lang#130273 (more eagerly discard constraints on overflow) - rust-lang#130276 (Add test for nalgebra hang in coherence) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2024
Rollup merge of rust-lang#130263 - Zalathar:sums, r=compiler-errors coverage: Simplify creation of sum counters A small and self-contained improvement, extracted from some larger changes that I'm still working on. Ultimately I want to avoid creating these sum counter-expressions in some cases (in favour of just adding physical counters directly to the nodes we care about), so a good incremental move towards that is splitting the “gather edge counters” step out from the ”build a sum of those counters” step. Creating an extra intermediate vector should have negligible cost (and coverage isn't exercised by the benchmark suite anyway). The removed logging is redundant with the `#[instrument(..)]` logging we already have on the underlying method calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small and self-contained improvement, extracted from some larger changes that I'm still working on.
Ultimately I want to avoid creating these sum counter-expressions in some cases (in favour of just adding physical counters directly to the nodes we care about), so a good incremental move towards that is splitting the “gather edge counters” step out from the ”build a sum of those counters” step.
Creating an extra intermediate vector should have negligible cost (and coverage isn't exercised by the benchmark suite anyway). The removed logging is redundant with the
#[instrument(..)]logging we already have on the underlying method calls.