more eagerly discard constraints on overflow #130273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
approved these changes
Sep 12, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 12, 2024
…mpiler-errors more eagerly discard constraints on overflow We always discard the results of overflowing goals inside of the trait solver. We previously did so when instantiating the response in `evaluate_goal`. Canonicalizing results only to later discard them is also inefficient 🤷 It's simpler and nicer to debug to eagerly discard constraints inside of the query itself. r? `@compiler-errors`
This was referenced Sep 12, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130101 (some const cleanup: remove unnecessary attributes, add const-hack indications) - rust-lang#130208 (Introduce `'ra` lifetime name.) - rust-lang#130263 (coverage: Simplify creation of sum counters) - rust-lang#130273 (more eagerly discard constraints on overflow) - rust-lang#130276 (Add test for nalgebra hang in coherence) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2024
Rollup merge of rust-lang#130273 - lcnr:overflow-no-constraints, r=compiler-errors more eagerly discard constraints on overflow We always discard the results of overflowing goals inside of the trait solver. We previously did so when instantiating the response in `evaluate_goal`. Canonicalizing results only to later discard them is also inefficient 🤷 It's simpler and nicer to debug to eagerly discard constraints inside of the query itself. r? ``@compiler-errors``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always discard the results of overflowing goals inside of the trait solver. We previously did so when instantiating the response in
evaluate_goal. Canonicalizing results only to later discard them is also inefficient 🤷It's simpler and nicer to debug to eagerly discard constraints inside of the query itself.
r? @compiler-errors