Only add an automatic SONAME for Rust dylibs #130960
Merged
+80
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Is the bot sleeping? trying again...) r? petrochenkov |
|
I also encountered a breaking change related to this. In my case, I was explicitly renaming the final shared library to something different (from libmylib_ffi.so to libmylib.so) to package it nicely and it broke my cgo bindings. It turned out that the cgo dynamic loader was very confused with a library file having a certain name and the SONAME being different. This wasn't a problem before since previously the shared library did not have a SONAME. I ultimately found a way around it but I bet it a broke a variety of subtle use cases for people. I was too lazy to open a GitHub issue at the time though as I initially thought the change was intented. |
petrochenkov
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
This fixes a stable-to-stable regression from Rust 1.81.0 (#126094). |
petrochenkov
added
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#128778 (atomics: allow atomic and non-atomic reads to race) - rust-lang#130918 (simplify LLVM submodule handling) - rust-lang#130960 (Only add an automatic SONAME for Rust dylibs) - rust-lang#130973 (compiletest: rename "runtest/crash.rs" to "runtest/crashes.rs" to be in line with the test directory) - rust-lang#130976 (remove couple redundant clones) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
Rollup merge of rust-lang#130960 - cuviper:cdylib-soname, r=petrochenkov Only add an automatic SONAME for Rust dylibs rust-lang#126094 added an automatic relative `SONAME` to all dynamic libraries, but it was really only needed for Rust `--crate-type="dylib"`. In Fedora, it was a surprise to see `SONAME` on `"cdylib"` libraries like Python modules, especially because that generates an undesirable RPM `Provides`. We can instead add a `SONAME` just for Rust dylibs by passing the crate-type argument farther. Ref: https://bugzilla.redhat.com/show_bug.cgi?id=2314879
rustbot
added
beta-accepted
Closed
2 tasks
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 11, 2024
[beta] backports - Only add an automatic SONAME for Rust dylibs rust-lang#130960 - Reject leading unsafe in `cfg!(...)` and `--check-cfg` rust-lang#131057, resolving rust-lang#131055 - Disable jump threading `UnOp::Not` for non-bool rust-lang#131201 - Update LLVM submodule rust-lang#131448 r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 11, 2024
[beta] backports - Only add an automatic SONAME for Rust dylibs rust-lang#130960 - Reject leading unsafe in `cfg!(...)` and `--check-cfg` rust-lang#131057, resolving rust-lang#131055 - Disable jump threading `UnOp::Not` for non-bool rust-lang#131201 - Update LLVM submodule rust-lang#131448 r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
[beta] backports - Only add an automatic SONAME for Rust dylibs rust-lang#130960 - Reject leading unsafe in `cfg!(...)` and `--check-cfg` rust-lang#131057, resolving rust-lang#131055 - Disable jump threading `UnOp::Not` for non-bool rust-lang#131201 - Update LLVM submodule rust-lang#131448 r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
[beta] backports - Only add an automatic SONAME for Rust dylibs rust-lang#130960 - Reject leading unsafe in `cfg!(...)` and `--check-cfg` rust-lang#131057, resolving rust-lang#131055 - Disable jump threading `UnOp::Not` for non-bool rust-lang#131201 - Update LLVM submodule rust-lang#131448 - Split x86_64-msvc-ext into two jobs rust-lang#130072 - Use a small runner for msvc-ext2 job rust-lang#130151 r? ghost
cuviper
removed
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#126094 added an automatic relative
SONAMEto all dynamic libraries, but it was really only needed for Rust--crate-type="dylib". In Fedora, it was a surprise to seeSONAMEon"cdylib"libraries like Python modules, especially because that generates an undesirable RPMProvides. We can instead add aSONAMEjust for Rust dylibs by passing the crate-type argument farther.Ref: https://bugzilla.redhat.com/show_bug.cgi?id=2314879