Update LLVM submodule

[DianQK]

Fixes (maybe after beta backport) #131164.

r? nikic

[rustbot]

⚠️ Warning ⚠️

• These commits modify submodules.

[DianQK]

Backporting will also bring #131293, mostly clang changes. I can create a separate branch for backporting if necessary.

[DianQK]

It broke something, I'll check it out tomorrow. 😣

[onur-ozkan]

Maybe reason is because download-rustc="if-unchanged" is being utilized in non-dist runners. If that's the case (you can set NO_DOWNLOAD_CI_RUSTC=1 in the failed runner for testing), we should add a logic to skip download-rustc on LLVM bumps.

[onur-ozkan]

Can you cherry pick commits from #131453 and #131305 (with reverting the last change)? I want to see if they can fix x86_64-gnu-llvm-18 and x86_64-gnu-tools issues.

Testing in #131455.

[jieyouxu]

thread 'core::config::tests::download_ci_llvm' panicked at src/core/config/tests.rs:34:5

Might need to rebase again?

[DianQK]

thread 'core::config::tests::download_ci_llvm' panicked at src/core/config/tests.rs:34:5

Might need to rebase again?

This is a known error: #131303.

[nikic]

@bors r+ rollup=never

[bors]

📌 Commit 4ea9711 has been approved by nikic

It is now in the queue for this repository.

[onur-ozkan]

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- core::config::tests::download_ci_llvm stdout ----
Detected LLVM as non-available: running in CI and modified LLVM in this change
thread 'core::config::tests::download_ci_llvm' panicked at src/core/config/tests.rs:24:5:
assertion failed: parse("").llvm_from_ci
   0: rust_begin_unwind
             at /rustc/8c27a2ba6b21f3406a51118643080f0591949827/library/std/src/panicking.rs:662:5
   1: core::panicking::panic_fmt
             at /rustc/8c27a2ba6b21f3406a51118643080f0591949827/library/core/src/panicking.rs:74:14

lol this is getting really annoying

[onur-ozkan]

Feel free to apply this patch:

diff --git a/src/bootstrap/src/core/config/tests.rs b/src/bootstrap/src/core/config/tests.rs
index 4b689aa3ecc..15600f70d6e 100644
--- a/src/bootstrap/src/core/config/tests.rs
+++ b/src/bootstrap/src/core/config/tests.rs
@@ -21,7 +21,6 @@ pub(crate) fn parse(config: &str) -> Config {

 #[test]
 fn download_ci_llvm() {
-    assert!(parse("").llvm_from_ci);
     assert!(parse("llvm.download-ci-llvm = true").llvm_from_ci);
     assert!(!parse("llvm.download-ci-llvm = false").llvm_from_ci);

as a first commit (make sure the LLVM submodule update is the last commit) and r=me.

[onur-ozkan]

Feel free to apply this patch:

diff --git a/src/bootstrap/src/core/config/tests.rs b/src/bootstrap/src/core/config/tests.rs
index 4b689aa3ecc..15600f70d6e 100644
--- a/src/bootstrap/src/core/config/tests.rs
+++ b/src/bootstrap/src/core/config/tests.rs
@@ -21,7 +21,6 @@ pub(crate) fn parse(config: &str) -> Config {

 #[test]
 fn download_ci_llvm() {
-    assert!(parse("").llvm_from_ci);
     assert!(parse("llvm.download-ci-llvm = true").llvm_from_ci);
     assert!(!parse("llvm.download-ci-llvm = false").llvm_from_ci);

as a first commit (make sure the LLVM submodule update is the last commit) and r=me.

or even ignore that test with #[ignore] completely. I guess that will be much better until we have a stabilized change tracking logic (something like #131358).

[rustbot]

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

[onur-ozkan]

@bors r+

[bors]

📌 Commit 4441a89 has been approved by onur-ozkan

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4441a89 with merge e200c7f...

[lqd]

The good news is that the backport has already landed on the beta branch

[cuviper]

Yes, but if #131560 lands before this, marking the version cutoff, then there will be a new beta needing backport .

[bors]

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing e200c7f to master...

[rust-timer]

Finished benchmarking commit (e200c7f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.3%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	2.3%	[0.9%, 3.7%]	3
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-2.0%, 1.4%]	2

Cycles

Results (secondary -5.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.1%	[-6.9%, -3.4%]	6
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.421s -> 779.831s (0.05%)
Artifact size: 332.13 MiB -> 332.07 MiB (-0.02%)