-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable download-rustc
if LLVM submodule has changes in CI
#131453
Conversation
This PR modifies If appropriate, please update |
Tested and it's fixed #131448 (comment) in #131455. |
2d13cda
to
77e3225
Compare
download-rustc
if LLVM submodule has changesdownload-rustc
if LLVM submodule has changes in CI
04e7cec
to
30c5080
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
30c5080
to
b198a46
Compare
Looks reasonable. As usually, I would like to move this logic outside of @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (de19f2b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.605s -> 775.399s (0.10%) |
We can't use CI rustc while using in-tree LLVM (which happens in LLVM submodule update PRs) and this PR handles that by ignoring CI-rustc in CI and failing in non-CI environments.