Make asm label blocks safe context #131544
Merged
+78
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`asm!()` is forced to be wrapped inside unsafe. If there's no special treatment, the label blocks would also always be unsafe with no way of opting out.
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
| Out { expr: None, reg: _, late: _ } | ||
| | Const { value: _, span: _ } | ||
| | SymFn { value: _, span: _ } | ||
| | SymStatic { def_id: _ } => {} |
There was a problem hiding this comment.
The default visitor uses visit_anon_const and visit_qpath in this place, don't you need them here?
To avoid potential mistakes, it probably makes sense to add a public fn walk_inline_asm_operand helper to intravisit.rs.
match op {
Label { .. } => self.in_safety_context(SafetyContext::Safe, walk_inline_asm_operand(...)),
_ => walk_inline_asm_operand(...),
}There was a problem hiding this comment.
This is the THIR visitor which doesn't have visit_anon_const and visit_qpath.
There was a problem hiding this comment.
ping @compiler-errors
There was a problem hiding this comment.
Sorry, pinged wrong person. @petrochenkov
There was a problem hiding this comment.
Sorry, I never noticed the update, it's better to set the S-waiting-on-review label if a PR is waiting on review.
If this part cannot be improved, then it's good to go.
petrochenkov
added
S-waiting-on-author
40 tasks
88 tasks
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 21, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#130236 (unstable feature usage metrics) - rust-lang#131544 (Make asm label blocks safe context) - rust-lang#131586 (Support s390x z13 vector ABI) - rust-lang#132489 (Fix closure arg extraction in `extract_callable_info`, generalize it to async closures) - rust-lang#133078 (tests: ui/inline-consts: add issue number to a test, rename other tests) - rust-lang#133283 (Don't exclude relnotes from `needs-triage` label) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 21, 2024
Rollup merge of rust-lang#131544 - nbdd0121:asm_goto_safe_block, r=petrochenkov Make asm label blocks safe context Tracking issue: rust-lang#119364 `asm!()` is forced to be wrapped inside unsafe. If there's no special treatment, the label blocks would also always be unsafe with no way of opting out. It was suggested that a simple fix is to make asm label blocks safe: rust-lang#119364 (comment). `@rustbot` labels: +A-inline-assembly +F-asm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #119364
asm!()is forced to be wrapped inside unsafe. If there's no special treatment, the label blocks would also always be unsafe with no way of opting out. It was suggested that a simple fix is to make asm label blocks safe: #119364 (comment).@rustbot labels: +A-inline-assembly +F-asm