Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ui/inline-consts: add issue number to a test, rename other tests #133078

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

matthiaskrgr
Copy link
Member

rename other tests from a_b_c to a-b-c

@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is actually #125846
This number is the PR, #125918

Can we add them both as links to the initial comments of this file? Perhaps a remark about how this is to catch a regression introduced by treating inline const blocks as the same as other anon consts?

@jieyouxu
Copy link
Member

jieyouxu commented Nov 16, 2024

@matthiaskrgr just curious, is there a specific reason for renaming the tests use - over _? Not that it matters.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 16, 2024
@matthiaskrgr
Copy link
Member Author

I just looked at what the majority of the other tests were doing 🤷

@matthiaskrgr matthiaskrgr added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2024
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 21, 2024

📌 Commit 98ab898 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 21, 2024
tests: ui/inline-consts: add issue number to a test, rename other tests

rename other tests from a_b_c to a-b-c
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130236 (unstable feature usage metrics)
 - rust-lang#131544 (Make asm label blocks safe context)
 - rust-lang#131586 (Support s390x z13 vector ABI)
 - rust-lang#132489 (Fix closure arg extraction in `extract_callable_info`, generalize it to async closures)
 - rust-lang#133078 (tests: ui/inline-consts: add issue number to a test, rename other tests)
 - rust-lang#133283 (Don't exclude relnotes from `needs-triage` label)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8259859 into rust-lang:master Nov 21, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
Rollup merge of rust-lang#133078 - matthiaskrgr:uiuiui, r=davidtwco

tests: ui/inline-consts: add issue number to a test, rename other tests

rename other tests from a_b_c to a-b-c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants