compiletest: Remove the one thing that was checking a directive's original_line
#131585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-testsuite
This comment was marked as outdated.
This comment was marked as outdated.
|
r? jieyouxu |
|
You can r=me after PR CI is green. |
|
🟩 @bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 12, 2024
compiletest: Remove the one thing that was checking a directive's `original_line` This special handling of `ignore-tidy*` was introduced during the migration to `//`@`` directives (rust-lang#120881), and has become unnecessary after the subsequent removal of the legacy directive check (rust-lang#131392).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#130870 (Add suggestion for removing invalid path sep `::` in fn def) - rust-lang#131233 (std: fix stdout-before-main) - rust-lang#131239 (Don't assume traits used as type are trait objs in 2021 edition) - rust-lang#131277 (Handle `clippy` cases of `rustc::potential_query_instability` lint) - rust-lang#131567 (Emit an error for unstable attributes that reference already stable features) - rust-lang#131585 (compiletest: Remove the one thing that was checking a directive's `original_line`) - rust-lang#131590 (yeet some clones) - rust-lang#131597 (Take a display name for `tool_check_step!`) r? `@ghost` `@rustbot` modify labels: rollup
|
Looks like this failed the rollup #131601 (comment) @bors r- |
bors
added
S-waiting-on-author
|
Ah of course, |
|
That does seem like the sort of thing that could be checked somewhere in PR CI |
|
Zalathar
force-pushed
the
original-line
branch
from
3d15d2d
to
b41a51f
Compare
Zalathar
force-pushed
the
original-line
branch
from
b41a51f
to
f510880
Compare
|
Rebased and fixed trivial doc issue (diff). I'm running a side job to double-check that there are no more problems, after which I'll reapply the r+. |
|
@bors r=jieyouxu |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#131086 (Update unicode-width to 0.2.0) - rust-lang#131585 (compiletest: Remove the one thing that was checking a directive's `original_line`) - rust-lang#131614 (Error on trying to use revisions in `run-make` tests) - rust-lang#131638 (compiletest: Move debugger setup code out of `lib.rs`) - rust-lang#131641 (switch unicode-data bitsets back to 'static') - rust-lang#131642 (Special case error message for a `build-fail` test that failed check build) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
Rollup merge of rust-lang#131585 - Zalathar:original-line, r=jieyouxu compiletest: Remove the one thing that was checking a directive's `original_line` This special handling of `ignore-tidy*` was introduced during the migration to `//`@`` directives (rust-lang#120881), and has become unnecessary after the subsequent removal of the legacy directive check (rust-lang#131392).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This special handling of
ignore-tidy*was introduced during the migration to//@directives (#120881), and has become unnecessary after the subsequent removal of the legacy directive check (#131392).