rustdoc: Rename "object safe" to "dyn compatible" #131594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
rustbot
added
A-rustdoc-json
fmease
commented
Oct 12, 2024
This was referenced Oct 12, 2024
notriddle
reviewed
Oct 12, 2024
|
Apart from notriddle's comments, looks good to me. :) |
fmease
force-pushed
the
rustdoc-mv-obj-safe-dyn-compat
branch
from
41751a4 to
d707530
Compare
fmease
force-pushed
the
rustdoc-mv-obj-safe-dyn-compat
branch
from
d707530 to
8a6eb2e
Compare
|
Suggestions applied. Ready. |
12 tasks
notriddle
reviewed
Oct 16, 2024
fmease
force-pushed
the
rustdoc-mv-obj-safe-dyn-compat
branch
from
8a6eb2e to
6d82559
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#130822 (Add `from_ref` and `from_mut` constructors to `core::ptr::NonNull`.) - rust-lang#131381 (Implement edition 2024 match ergonomics restrictions) - rust-lang#131594 (rustdoc: Rename "object safe" to "dyn compatible") - rust-lang#131686 (Add fast-path when computing the default visibility) - rust-lang#131699 (Try to improve error messages involving aliases in the solver) - rust-lang#131757 (Ignore lint-non-snake-case-crate#proc_macro_ on targets without unwind) - rust-lang#131783 (Fix explicit_iter_loop in rustc_serialize) - rust-lang#131788 (Fix mismatched quotation mark) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
Rollup merge of rust-lang#131594 - fmease:rustdoc-mv-obj-safe-dyn-compat, r=notriddle rustdoc: Rename "object safe" to "dyn compatible" Supersedes rust-lang#126554: 1. In line with [T-lang's latest resolution](rust-lang/lang-team#286 (comment)). 2. More comprehensive: Not only updates user-facing text but also source code. Part of rust-lang#130852. Doesn't update rustdoc-JSON (will be filed separately). r? `@notriddle` (rust-lang/lang-team#286) `@GuillaumeGomez` (for visibility)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2024
…compat, r=aDotInTheVoid rustdoc-JSON: Rename "object safe" to "dyn compatible" ~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased) Part of rust-lang#130852. r? aDotInTheVoid or rustdoc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2024
…compat, r=aDotInTheVoid rustdoc-JSON: Rename "object safe" to "dyn compatible" ~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased) Part of rust-lang#130852. r? aDotInTheVoid or rustdoc
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 17, 2024
…n-compat, r=aDotInTheVoid rustdoc-JSON: Rename "object safe" to "dyn compatible" ~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased) Part of rust-lang#130852. r? aDotInTheVoid or rustdoc
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2024
Rollup merge of rust-lang#131595 - fmease:rustdoc-json-mv-obj-safe-dyn-compat, r=aDotInTheVoid rustdoc-JSON: Rename "object safe" to "dyn compatible" ~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased) Part of rust-lang#130852. r? aDotInTheVoid or rustdoc
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 22, 2025
…pat-ii, r=GuillaumeGomez rustdoc: Finalize dyn compatibility renaming Update the Reference link to use the new URL fragment from rust-lang/reference#1666 (this change has finally hit stable). Fixes a FIXME. Follow-up to rust-lang#131594. Part of rust-lang#130852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #126554:
Part of #130852.
Doesn't update rustdoc-JSON (
will befiled separately. #131595).r? @notriddle (rust-lang/lang-team#286) @GuillaumeGomez (for visibility)