Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Finalize dyn compatibility renaming #135858

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

fmease
Copy link
Member

@fmease fmease commented Jan 22, 2025

Update the Reference link to use the new URL fragment from rust-lang/reference#1666 (this change has finally hit stable). Fixes a FIXME.

Follow-up to #131594.
Part of #130852.

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 22, 2025
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 22, 2025

📌 Commit ff7cf14 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#133372 (Refactor dyn-compatibility error and suggestions)
 - rust-lang#134396 (AIX: use align 8 for byval parameter)
 - rust-lang#135156 (Make our `DIFlags` match `LLVMDIFlags` in the LLVM-C API)
 - rust-lang#135816 (Use `structurally_normalize` instead of manual `normalizes-to` goals in alias relate errors)
 - rust-lang#135823 (make UI tests that use `--test` work on panic=abort targets)
 - rust-lang#135850 (Update the `wasm-component-ld` tool)
 - rust-lang#135858 (rustdoc: Finalize dyn compatibility renaming)
 - rust-lang#135866 (Don't pick `T: FnPtr` nested goals as the leaf goal in diagnostics for new solver)
 - rust-lang#135874 (Enforce that all spans are lowered in ast lowering)
 - rust-lang#135875 (Remove `Copy` bound from `enter_forall`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 413f87a into rust-lang:master Jan 22, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2025
rustdoc-json-types: Finalize dyn compatibility renaming

Followup to rust-lang#131595.

Part of rust-lang#130852.

Inspired by rust-lang#135858 (does the same thing but for the rustdoc-types docs).

r? `@fmease`
@fmease fmease deleted the rustdoc-mv-obj-save-dyn-compat-ii branch January 22, 2025 23:15
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 23, 2025
rustdoc-json-types: Finalize dyn compatibility renaming

Followup to rust-lang#131595.

Part of rust-lang#130852.

Inspired by rust-lang#135858 (does the same thing but for the rustdoc-types docs).

r? ``@fmease``
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jan 23, 2025
rustdoc-json-types: Finalize dyn compatibility renaming

Followup to rust-lang#131595.

Part of rust-lang#130852.

Inspired by rust-lang#135858 (does the same thing but for the rustdoc-types docs).

r? ```@fmease```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 23, 2025
rustdoc-json-types: Finalize dyn compatibility renaming

Followup to rust-lang#131595.

Part of rust-lang#130852.

Inspired by rust-lang#135858 (does the same thing but for the rustdoc-types docs).

r? ````@fmease````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants