miri: update ABI compat checks to accept Option-like types #132057
Merged
+59
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
RalfJung
force-pushed
the
miri-abi-compat
branch
from
74b967c
to
bce5cba
Compare
|
☔ The latest upstream changes (presumably #132581) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
force-pushed
the
miri-abi-compat
branch
from
bce5cba
to
b2fe71a
Compare
|
@rust-lang/miri any chance one of you could review this? :) |
wesleywiser
approved these changes
Nov 7, 2024
|
r=me unless you want another review from @rust-lang/miri 🙂 |
|
Thanks. :) |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#132057 (miri: update ABI compat checks to accept Option-like types) - rust-lang#132665 (Implement `div_ceil` for `NonZero<unsigned>`) - rust-lang#132694 (fix(x): fix a regex used to find python executable) - rust-lang#132707 (Add --diagnostic-width to some tests failing after 1a0c502) - rust-lang#132715 (fix `LazyLock::get` and `LazyLock::get_mut` document) - rust-lang#132716 (chore(issue-template): fix branch name) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2024
Rollup merge of rust-lang#132057 - RalfJung:miri-abi-compat, r=wesleywiser miri: update ABI compat checks to accept Option-like types This implements the t-lang decision described [here](rust-lang#130628 (comment)). Fixes rust-lang/miri#3983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the t-lang decision described here.
Fixes rust-lang/miri#3983