Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement div_ceil for NonZero<unsigned> #132665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tyilo
Copy link
Contributor

@tyilo tyilo commented Nov 5, 2024

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 5, 2024
without modifying the original"]
#[inline]
pub const fn div_ceil(self, rhs: Self) -> Self {
let v = self.get().div_ceil(rhs.get());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you inline div_ceil here? That will lead to unchecked operations being used for the division and remainder which might allow some more optimizations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean something like the following?

pub const fn div_ceil(self, rhs: Self) -> Self {
  let a = self.get();
  let b = rhs.get();
  let d = a / b;
  let r = a % b;
  let v = if r > 0 {
    d + 1
  } else {
    d
  };
  // SAFETY: ceiled division of two positive integers can never be zero.
  unsafe { Self::new_unchecked(v) }
}

Why would this allow more optimizations? They seem to produce the same ASM: https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=735568e0474e49fa0a1b86d773a486d0

@tyilo tyilo requested a review from joboet November 6, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants