Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement OsString::truncate #133264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement OsString::truncate #133264

wants to merge 1 commit into from
+8 −4

Conversation

lolbinarycat
Copy link
Contributor

part of #133262

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2024
@lolbinarycat
Copy link
Contributor Author

because this is replacing an existing function that is presumably used for path manipulations, it should be benchmarked.

if there are regressions, we can add an internal "unchecked" version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joboet joboet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolbinarycat @rustbot @joboet