Pretty print async fn sugar in opaques and trait bounds #132911
+133
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Could not assign reviewer from: |
compiler-errors
commented
Nov 11, 2024
| let generics = tcx.generics_of(trait_ref.def_id); | ||
| let own_args = generics.own_args_no_defaults(tcx, trait_ref.args); | ||
|
|
||
| match (entry.return_ty, own_args[0].expect_ty()) { |
There was a problem hiding this comment.
I have noooooooOOoOooooooo idea wtf was going on here lmao
compiler-errors
commented
Nov 11, 2024
| @@ -1230,51 +1206,48 @@ pub trait PrettyPrinter<'tcx>: Printer<'tcx> + fmt::Write { | |||
| /// traits map or fn_traits map, depending on if the trait is in the Fn* family of traits. | |||
| fn insert_trait_and_projection( | |||
There was a problem hiding this comment.
I'm pretty disappointed with how sensitive to bound var renumbering this is... but 🤷
compiler-errors
force-pushed
the
async-fn-sugar
branch
from
89b92c5
to
d617f18
Compare
compiler-errors
commented
Nov 11, 2024
| if let Some(return_ty) = entry.return_ty { | ||
| self.wrap_binder(&bound_args, |args, cx| { | ||
| define_scoped_cx!(cx); | ||
| p!(write("{}", tcx.item_name(trait_def_id))); |
There was a problem hiding this comment.
we could very easily start making this print like async Fn in the future.
compiler-errors
force-pushed
the
async-fn-sugar
branch
from
d617f18
to
d460ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sudo r? fmease